[PATCH v2] mem: fix displaying heap ID failed for heap info command
Huisong Li
lihuisong at huawei.com
Wed Feb 22 08:49:53 CET 2023
The telemetry lib has added a allowed characters set for dictionary names.
Please see commit 2537fb0c5f34 ("telemetry: limit characters allowed in
dictionary names")
The space is not in this set, which cause the heap ID in /eal/heap_info
cannot be displayed. Additionally, 'heap' is also misspelling. So use
'Heap_id' to replace 'Head id'.
Fixes: e6732d0d6e26 ("mem: add telemetry infos")
Fixes: 2537fb0c5f34 ("telemetry: limit characters allowed in dictionary names")
Cc: stable at dpdk.org
Signed-off-by: Huisong Li <lihuisong at huawei.com>
Acked-by: Chengwen Feng <fengchengwen at huawei.com>
---
-v2: add announcement in rel_notes.
---
doc/guides/rel_notes/release_23_03.rst | 2 ++
lib/eal/common/eal_common_memory.c | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/doc/guides/rel_notes/release_23_03.rst b/doc/guides/rel_notes/release_23_03.rst
index 49c18617a5..bdee535046 100644
--- a/doc/guides/rel_notes/release_23_03.rst
+++ b/doc/guides/rel_notes/release_23_03.rst
@@ -237,6 +237,8 @@ API Changes
* The experimental structures ``struct rte_graph_param``, ``struct rte_graph``
and ``struct graph`` were updated to support pcap trace in the graph library.
+* The ``Head ip`` in the displaying of ``/eal/heap_info`` telemetry command
+ is modified to ``Heap_id`` to ensure that it can be printed.
ABI Changes
-----------
diff --git a/lib/eal/common/eal_common_memory.c b/lib/eal/common/eal_common_memory.c
index c917b981bc..c2a4c8f9e7 100644
--- a/lib/eal/common/eal_common_memory.c
+++ b/lib/eal/common/eal_common_memory.c
@@ -1139,7 +1139,7 @@ handle_eal_heap_info_request(const char *cmd __rte_unused, const char *params,
malloc_heap_get_stats(heap, &sock_stats);
rte_tel_data_start_dict(d);
- rte_tel_data_add_dict_uint(d, "Head id", heap_id);
+ rte_tel_data_add_dict_uint(d, "Heap_id", heap_id);
rte_tel_data_add_dict_string(d, "Name", heap->name);
rte_tel_data_add_dict_uint(d, "Heap_size",
sock_stats.heap_totalsz_bytes);
--
2.33.0
More information about the dev
mailing list