[PATCH v2 16/16] test/bbdev: remove iter count from bler test

Maxime Coquelin maxime.coquelin at redhat.com
Wed Feb 22 12:01:44 CET 2023



On 2/15/23 18:09, Hernan Vargas wrote:
> iter_count doesn't need to be set equal to iter_max for bler tests. This
> is only needed in throughput and latency tests because early termination
> is disabled for those tests.
> 
> Signed-off-by: Hernan Vargas <hernan.vargas at intel.com>
> ---
>   app/test-bbdev/test_bbdev_perf.c | 16 ++++++----------
>   1 file changed, 6 insertions(+), 10 deletions(-)
> 
> diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
> index 2baa2a0e62..621feee42b 100644
> --- a/app/test-bbdev/test_bbdev_perf.c
> +++ b/app/test-bbdev/test_bbdev_perf.c
> @@ -3714,12 +3714,10 @@ bler_pmd_lcore_ldpc_dec(void *arg)
>   	TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", num_ops);
>   
>   	/* For BLER tests we need to enable early termination */
> -	if (!check_bit(ref_op->ldpc_dec.op_flags,
> -			RTE_BBDEV_LDPC_ITERATION_STOP_ENABLE))
> -		ref_op->ldpc_dec.op_flags +=
> -				RTE_BBDEV_LDPC_ITERATION_STOP_ENABLE;
> +	if (!check_bit(ref_op->ldpc_dec.op_flags, RTE_BBDEV_LDPC_ITERATION_STOP_ENABLE))
> +		ref_op->ldpc_dec.op_flags += RTE_BBDEV_LDPC_ITERATION_STOP_ENABLE;
> +
>   	ref_op->ldpc_dec.iter_max = get_iter_max();
> -	ref_op->ldpc_dec.iter_count = ref_op->ldpc_dec.iter_max;
>   
>   	if (test_vector.op_type != RTE_BBDEV_OP_NONE)
>   		copy_reference_ldpc_dec_op(ops_enq, num_ops, 0, bufs->inputs,
> @@ -3838,12 +3836,10 @@ bler_pmd_lcore_turbo_dec(void *arg)
>   	TEST_ASSERT_SUCCESS(ret, "Allocation failed for %d ops", num_ops);
>   
>   	/* For BLER tests we need to enable early termination */
> -	if (!check_bit(ref_op->turbo_dec.op_flags,
> -			RTE_BBDEV_TURBO_EARLY_TERMINATION))
> -		ref_op->turbo_dec.op_flags +=
> -				RTE_BBDEV_TURBO_EARLY_TERMINATION;
> +	if (!check_bit(ref_op->turbo_dec.op_flags, RTE_BBDEV_TURBO_EARLY_TERMINATION))
> +		ref_op->turbo_dec.op_flags += RTE_BBDEV_TURBO_EARLY_TERMINATION;
> +
>   	ref_op->turbo_dec.iter_max = get_iter_max();
> -	ref_op->turbo_dec.iter_count = ref_op->turbo_dec.iter_max;
>   
>   	if (test_vector.op_type != RTE_BBDEV_OP_NONE)
>   		copy_reference_dec_op(ops_enq, num_ops, 0, bufs->inputs,

Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>

Thanks,
Maxime



More information about the dev mailing list