[PATCH v7 03/21] net/cpfl: add Rx queue setup

Ferruh Yigit ferruh.yigit at amd.com
Mon Feb 27 22:46:18 CET 2023


On 2/16/2023 12:29 AM, Mingxia Liu wrote:
> Add support for rx_queue_setup ops.
> 
> Signed-off-by: Mingxia Liu <mingxia.liu at intel.com>

<...>

> +
> +	if (bufq_id == 1) {
> +		rxq->bufq1 = bufq;
> +	} else if (bufq_id == 2) {
> +		rxq->bufq2 = bufq;

For readability better to use enums to diffrentiate queues, instead of
using 1 and 2 as paramter to function.

Also I wonder if queue variable names can be improved too, from 'bufq1'
& 'bufq2' to something more descriptive.


More information about the dev mailing list