[PATCH v7 12/21] net/cpfl: support RSS

[Ferruh Yigit]

On 2/28/2023 11:28 AM, Liu, Mingxia wrote:
> 
> 
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit at amd.com>
>> Sent: Tuesday, February 28, 2023 5:50 AM
>> To: Liu, Mingxia <mingxia.liu at intel.com>; dev at dpdk.org; Xing, Beilei
>> <beilei.xing at intel.com>; Zhang, Yuying <yuying.zhang at intel.com>
>> Subject: Re: [PATCH v7 12/21] net/cpfl: support RSS
>>
>> On 2/16/2023 12:30 AM, Mingxia Liu wrote:
>>> Add RSS support.
>>>
>>> Signed-off-by: Mingxia Liu <mingxia.liu at intel.com>
>>
>> <...>
>>
>>>  static int
>>>  cpfl_dev_configure(struct rte_eth_dev *dev)  {
>>>  	struct idpf_vport *vport = dev->data->dev_private;
>>>  	struct rte_eth_conf *conf = &dev->data->dev_conf;
>>> +	struct idpf_adapter *adapter = vport->adapter;
>>> +	int ret;
>>>
>>>  	if (conf->link_speeds & RTE_ETH_LINK_SPEED_FIXED) {
>>>  		PMD_INIT_LOG(ERR, "Setting link speed is not supported");
>> @@ -205,6
>>> +245,17 @@ cpfl_dev_configure(struct rte_eth_dev *dev)
>>>  		return -ENOTSUP;
>>>  	}
>>>
>>> +	if (adapter->caps.rss_caps != 0 && dev->data->nb_rx_queues != 0) {
>>> +		ret = cpfl_init_rss(vport);
>>> +		if (ret != 0) {
>>> +			PMD_INIT_LOG(ERR, "Failed to init rss");
>>> +			return ret;
>>> +		}
>>> +	} else {
>>> +		PMD_INIT_LOG(ERR, "RSS is not supported.");
>>> +		return -1;
>>> +	}
>>
>>
>> Shouldn't driver take into account 'conf->rxmode->mq_mode' and 'conf-
>>> rx_adv_conf->rss_conf->*' ?
> [Liu, Mingxia] Thanks for your comments, we will add checking of 'conf->rxmode->mq_mode'.
> As for 'conf- >rx_adv_conf->rss_conf->*', we checked rss_conf->rss_key_len and rss_conf->rss_key in cpfl_dev_configure()-> cpfl_init_rss().
> 
> But for now pmd only support default rss_hf according to packge, so ignore the conf->rx_adv_conf->rss_conf->rss_hf.
> In the future, it will support configuring rss_hf.
> 

ack, thanks.