[PATCH] cryptodev: increase default max nb queue pairs

[Anoob Joseph]

Hi Ruifeng,

> Crypto device has devargs "max_nb_queue_pairs" which can be used to change
> queue pairs limit at init time.
> Then no need to increase the default value?

Yes. Thanks for the pointer. This field would suffice for the issue that I'm trying to fix.

Thanks,
Anoob

> -----Original Message-----
> From: Ruifeng Wang <Ruifeng.Wang at arm.com>
> Sent: Tuesday, January 10, 2023 12:12 PM
> To: Anoob Joseph <anoobj at marvell.com>; Akhil Goyal <gakhil at marvell.com>;
> Gagandeep Singh <g.singh at nxp.com>; hemant.agrawal at nxp.com; Kai Ji
> <kai.ji at intel.com>; Pablo de Lara <pablo.de.lara.guarch at intel.com>; Matan
> Azrad <matan at nvidia.com>; Zhangfei Gao <zhangfei.gao at linaro.org>; Fan
> Zhang <fanzhang.oss at gmail.com>
> Cc: Ashwin Sekhar T K <asekhar at marvell.com>; Jerin Jacob Kollanukkaran
> <jerinj at marvell.com>; dev at dpdk.org; nd <nd at arm.com>
> Subject: [EXT] RE: [PATCH] cryptodev: increase default max nb queue pairs
> 
> External Email
> 
> ----------------------------------------------------------------------
> > -----Original Message-----
> > From: Anoob Joseph <anoobj at marvell.com>
> > Sent: Wednesday, January 4, 2023 3:30 PM
> > To: Akhil Goyal <gakhil at marvell.com>; Ruifeng Wang
> > <Ruifeng.Wang at arm.com>; Gagandeep Singh <g.singh at nxp.com>;
> > hemant.agrawal at nxp.com; Kai Ji <kai.ji at intel.com>; Pablo de Lara
> > <pablo.de.lara.guarch at intel.com>; Matan Azrad <matan at nvidia.com>;
> > Zhangfei Gao <zhangfei.gao at linaro.org>; Fan Zhang
> > <fanzhang.oss at gmail.com>
> > Cc: Ashwin Sekhar T K <asekhar at marvell.com>; jerinj at marvell.com;
> > dev at dpdk.org
> > Subject: [PATCH] cryptodev: increase default max nb queue pairs
> >
> > Increase default maximum number of queue pairs to 64. For sw crypto
> > PMDs, the number of queue pairs can be increased as required. The
> > default value (which is set to 8), prevents usage of sw cryptodev PMDs with
> larger number of cores.
> >
> > Application would be allowed to specify the number of queue pairs it
> > wishes to use. Only the upper bound is changed from 8 to 64.
> >
> > Allow PMDs such as crypto_armv8 to run on larger number of cores.
> >
> > Signed-off-by: Anoob Joseph <anoobj at marvell.com>
> > ---
> >  lib/cryptodev/cryptodev_pmd.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/cryptodev/cryptodev_pmd.h
> > b/lib/cryptodev/cryptodev_pmd.h index
> > 0020102eb7..913a8f3623 100644
> > --- a/lib/cryptodev/cryptodev_pmd.h
> > +++ b/lib/cryptodev/cryptodev_pmd.h
> > @@ -29,7 +29,7 @@ extern "C" {
> >  #include "rte_cryptodev.h"
> >
> >
> > -#define RTE_CRYPTODEV_PMD_DEFAULT_MAX_NB_QUEUE_PAIRS	8
> > +#define RTE_CRYPTODEV_PMD_DEFAULT_MAX_NB_QUEUE_PAIRS	64
> >
> >  #define RTE_CRYPTODEV_PMD_NAME_ARG			("name")
> >  #define RTE_CRYPTODEV_PMD_MAX_NB_QP_ARG
> 	("max_nb_queue_pairs")
> 
> Crypto device has devargs "max_nb_queue_pairs" which can be used to change
> queue pairs limit at init time.
> Then no need to increase the default value?
> 
> > --
> > 2.25.1