[PATCH v7 2/5] eal: remove thread getname API
Tyler Retzlaff
roretzla at linux.microsoft.com
Tue Jan 24 16:33:36 CET 2023
On Tue, Jan 24, 2023 at 04:24:04PM +0100, Thomas Monjalon wrote:
> 23/01/2023 20:39, Tyler Retzlaff:
> > Remove the rte_thread_getname API. The API is __rte_experimental and
> > requires no deprecation notice.
>
> You should give a justification in this commit log,
> and note the removal in the release notes (removed items).
>
> > Fold the platform specific variants into the one place it is used as a
> > special case to retain the functionality for linux only.
> >
> > Adjust the function as follows.
> >
> > * reduce scope where thread_get_name can be used to eal_common_trace.c
> > * change the return type to void since the return value is not
> > consistent reportable depending on glibc version.
> > * change the thread id type to be rte_thread_t.
> >
> > Signed-off-by: Tyler Retzlaff <roretzla at linux.microsoft.com>
> >
> > Acked-by: Morten Brørup <mb at smartsharesystems.com>
> > Acked-by: Jerin Jacob <jerinj at marvell.com>
>
> Note: no space before acks.
>
noted, will make the adjustment in the future.
thanks for letting me know.
More information about the dev
mailing list