[PATCH v5 1/2] ethdev: fix ethdev configuration state on reset

[Ferruh Yigit]

On 1/18/2023 10:29 AM, Thomas Monjalon wrote:
> 21/12/2022 03:07, Hanumanth Pothula:
>> Presently, on device reset, ethdev configuration state,
>> dev_configured, is not reset.
>>
>> On device reset, reset ethdev configuration state to make
>> sure device reconfiguration happens cleanly.
>>
>> Signed-off-by: Hanumanth Pothula <hpothula at marvell.com>
> 
> A "Fixes" line is missing to show the root cause and help backports.
> 

It should be following, that is when 'dev_configured' flag is introduced
but not updated in 'rte_eth_dev_reset()':

Fixes: 02edbfab1e7d ("ethdev: add dev configured flag")
Cc: stable at dpdk.org
Cc: lihuisong at huawei.com


@Hanumanth, can you please send a new version with above fixes line and
below syntax fix?


>> --- a/lib/ethdev/rte_ethdev.c
>> +++ b/lib/ethdev/rte_ethdev.c
>> @@ -1629,6 +1629,8 @@ rte_eth_dev_reset(uint16_t port_id)
>>  			port_id, rte_strerror(-ret));
>>  	}
>>  	ret = dev->dev_ops->dev_reset(dev);
>> +	if (!ret)
> 
> Should be if (ret == 0)
> 
>> +		dev->data->dev_configured = 0;
> 
> 
>