[EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

[Nithin Kumar Dabilpuram]

> -----Original Message-----
> From: Thomas Monjalon <thomas at monjalon.net>
> Sent: Friday, January 27, 2023 2:25 PM
> To: Nithin Kumar Dabilpuram <ndabilpuram at marvell.com>
> Cc: Aman Singh <aman.deep.singh at intel.com>; Yuying Zhang <yuying.zhang at intel.com>;
> Ivan Malov <ivan.malov at oktetlabs.ru>; Andrew Rybchenko
> <andrew.rybchenko at oktetlabs.ru>; dev at dpdk.org; Hanumanth Reddy Pothula
> <hpothula at marvell.com>; Ferruh Yigit <ferruh.yigit at amd.com>; viacheslavo at nvidia.com;
> Jerin Jacob Kollanukkaran <jerinj at marvell.com>; david.marchand at redhat.com
> Subject: Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata
> negotiation
> 
> 27/01/2023 06:02, Nithin Kumar Dabilpuram:
> > From: Thomas Monjalon <thomas at monjalon.net>
> > > Ferruh is proposing to have a command "port config <port_id> ..."
> > > to configure the flags to negotiate.
> > > Are you OK with this approach?
> >
> > Yes, we are fine to have such command to enable and disable the feature
> > with default being it disabled if supported by PMD.
> > Is default being disabled fine if the feature is supported by a PMD ?
> 
> I think the default should be enabled for ease of use.

Since testpmd is used extensively for benchmarking purposes, we thought it should have minimum features
enabled by default. The default testpmd doesn't have any Rx/Tx offloads enabled(except for FAST FREE),  default
fwd mode being "iofwd" and the Rx metadata is only referenced when dumping packets.


> Do we have similar features disables by default?
> I mean do we know features in testpmd which require a "double enablement"
> like one configuration command + one rte_flow rule?

Spec itself is that way i.e "RTE_FLOW_RULE + RX_METADATA_NEGOTIATE(once)"

Isn't it enough if 

#1 We have enough print when rte_flow is being create without negotiation done and ask user to enable rx metadata using
"port config <port_id>..."
#2 Provide testpmd app arg to enable Rx metadata(for example " --rx-metadata") like other features to avoid calling another
command before rte flow create.

> 
>