[PATCH v3] log: add timestamp for log
Tyler Retzlaff
roretzla at linux.microsoft.com
Mon Mar 6 22:00:17 CET 2023
On Sat, Mar 04, 2023 at 08:04:41AM -0800, Stephen Hemminger wrote:
> On Sat, 4 Mar 2023 16:14:21 +0800
> luzhipeng <luzhipeng at cestc.cn> wrote:
>
> > From: Zhipeng Lu <luzhipeng at cestc.cn>
> >
> > add timestamp for log
> >
> > Signed-off-by: Zhipeng Lu <luzhipeng at cestc.cn>
>
> Good idea but:
> - it needs to be optional
> - timestamp only makes sense on the terminal (stdout) log stream
> syslog/journal already have timestamp
+1
also, some people who may have written scripts to consume the log output
might get kind of irritated that you suddenly broke the format of the
output. while not strictly an "api" it's not super friendly to break it
unnecessarily.
>
>
> I did a similar patch that never made it in that did this.
> https://patchwork.dpdk.org/project/dpdk/patch/20200814173441.23086-1-stephen@networkplumber.org/
More information about the dev
mailing list