[PATCH] service: split tests to perf and autotest to avoid spurious CI failures
David Marchand
david.marchand at redhat.com
Tue Mar 7 14:48:46 CET 2023
On Fri, Mar 3, 2023 at 11:59 AM Van Haaren, Harry
<harry.van.haaren at intel.com> wrote:
> > > + .setup = testsuite_setup,
> > > + .teardown = testsuite_teardown,
> > > + .unit_test_cases = {
> > > + TEST_CASE_ST(dummy_register, NULL, service_attr_get),
> > > + TEST_CASE_ST(dummy_register, NULL, service_lcore_attr_get),
> > > + TEST_CASE_ST(dummy_register, NULL, service_lcore_start_stop),
> >
> > Looking at service_lcore_running_check(), don't you think
> > service_may_be_active() and service_active_two_cores() are also
> > subject to race?
>
> Perhaps, but those haven't *actually* been failing in any of the reports.
> I'd prefer leave tests running if they're not causing issues in the CI.
service_may_be_active did fail in the near past (report from October
that triggered the discussion and the timeout extension patch).
So my fear is that we will see some ocurrences.
Time will tell.
--
David Marchand
More information about the dev
mailing list