[PATCH v4 06/12] app/mldev: add test case to interleave inferences

Thomas Monjalon thomas at monjalon.net
Thu Mar 9 21:15:56 CET 2023


07/02/2023 16:49, Srikanth Yalavarthi:
> -			ml_err("error_code = 0x%016lx, error_message = %s\n", error.errcode,
> +			ml_err("error_code = 0x%" PRIx64 ", error_message = %s\n", error.errcode,
>  			       error.message);
>  		}
>  		req = (struct ml_request *)op->user_ptr;
> @@ -334,10 +334,10 @@ ml_request_initialize(struct rte_mempool *mp, void *opaque, void *obj, unsigned
>  	RTE_SET_USED(mp);
>  	RTE_SET_USED(obj_idx);
>  
> -	req->input = RTE_PTR_ADD(
> -		obj, RTE_ALIGN_CEIL(sizeof(struct ml_request), t->cmn.dev_info.min_align_size));
> -	req->output = RTE_PTR_ADD(req->input, RTE_ALIGN_CEIL(t->model[t->fid].inp_qsize,
> -							     t->cmn.dev_info.min_align_size));
> +	req->input = (uint8_t *)obj +
> +		     RTE_ALIGN_CEIL(sizeof(struct ml_request), t->cmn.dev_info.min_align_size);
> +	req->output = req->input +
> +		      RTE_ALIGN_CEIL(t->model[t->fid].inp_qsize, t->cmn.dev_info.min_align_size);
>  	req->niters = 0;
>  
>  	/* quantize data */
> @@ -387,7 +387,7 @@ ml_inference_iomem_setup(struct ml_test *test, struct ml_options *opt, uint16_t
>  	}
>  
>  	t->model[fid].input = mz->addr;
> -	t->model[fid].output = RTE_PTR_ADD(t->model[fid].input, t->model[fid].inp_dsize);
> +	t->model[fid].output = t->model[fid].input + t->model[fid].inp_dsize;

So you are fixing your previous patch in an unrelated patch?

Really I cannot merge this mess in this state.
Please provide cleaner patches in v5.




More information about the dev mailing list