[PATCH v2] reorder: fix registration of dynamic field in mbuf

Volodymyr Fialko vfialko at marvell.com
Wed Mar 15 16:29:37 CET 2023


Hi,

A gentle reminder, please review and ack/comment.
Can we have this merged before RC3?

> -----Original Message-----
> From: Volodymyr Fialko <vfialko at marvell.com>
> Sent: Monday, March 13, 2023 2:04 PM
> To: dev at dpdk.org; Reshma Pattan <reshma.pattan at intel.com>; David Marchand
> <david.marchand at redhat.com>; Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>
> Cc: Jerin Jacob Kollanukkaran <jerinj at marvell.com>; Anoob Joseph <anoobj at marvell.com>; Volodymyr
> Fialko <vfialko at marvell.com>; stable at dpdk.org
> Subject: [PATCH v2] reorder: fix registration of dynamic field in mbuf
> 
> It's possible to initialize reorder buffer with user allocated memory via
> rte_reorder_init() function. In such case rte_reorder_create() is not required and reorder dynamic field in
> rte_mbuf will not be registered.
> 
> Both reorder lib and mbuf dynamic field are using `rte_mcfg_tailq` read/write lock for synchronization, to
> avoid deadlocking move reorder buffer initialization before queue insertion.
> 
> Fixes: 01f3496695b5 ("reorder: switch sequence number to dynamic mbuf field")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Volodymyr Fialko <vfialko at marvell.com>
> ---
>  lib/reorder/rte_reorder.c | 94 +++++++++++++++++++++++++--------------
>  lib/reorder/rte_reorder.h |  1 +
>  2 files changed, 61 insertions(+), 34 deletions(-)
<snip>


More information about the dev mailing list