[EXT] Re: [PATCH v2 1/1] ml/cnxk: fix multiple coverity issues

[Thomas Monjalon]

16/03/2023 18:02, Srikanth Yalavarthi:
> > -----Original Message-----
> > From: Thomas Monjalon <thomas at monjalon.net>
> > Sent: 16 March 2023 22:30
> > To: Srikanth Yalavarthi <syalavarthi at marvell.com>
> > Cc: Prince Takkar <ptakkar at marvell.com>; Shivah Shankar Shankar Narayan
> > Rao <sshankarnara at marvell.com>; dev at dpdk.org; Anup Prabhu
> > <aprabhu at marvell.com>
> > Subject: [EXT] Re: [PATCH v2 1/1] ml/cnxk: fix multiple coverity issues
> > 
> > External Email
> > 
> > ----------------------------------------------------------------------
> > 16/03/2023 10:33, Srikanth Yalavarthi:
> > > Added checks for null pointers. Removed logically dead code.
> > > Fix division or modulo by zero. Fix evaluation order violation issues.
> > > Fix potential memory leak in xstats function.
> > 
> > I think it would be better to split this patch a little, so we can easily see what
> > are the reasons for the changes.
> 
> Separate patch for each Coverity issue?

Maybe yes.
Or try to group similar causes.