[EXT] Re: [PATCH v6 05/12] app/mldev: add ordered inference test case

Srikanth Yalavarthi syalavarthi at marvell.com
Thu Mar 16 22:31:10 CET 2023


> -----Original Message-----
> From: Thomas Monjalon <thomas at monjalon.net>
> Sent: 16 March 2023 23:32
> To: Srikanth Yalavarthi <syalavarthi at marvell.com>
> Cc: dev at dpdk.org; Shivah Shankar Shankar Narayan Rao
> <sshankarnara at marvell.com>; Jerin Jacob Kollanukkaran
> <jerinj at marvell.com>; Anup Prabhu <aprabhu at marvell.com>; Prince Takkar
> <ptakkar at marvell.com>; Parijat Shukla <pshukla at marvell.com>; Srikanth
> Yalavarthi <syalavarthi at marvell.com>
> Subject: Re: [EXT] Re: [PATCH v6 05/12] app/mldev: add ordered inference
> test case
> 
> 16/03/2023 18:47, Srikanth Yalavarthi:
> > From: Thomas Monjalon <thomas at monjalon.net>
> > > 11/03/2023 16:08, Srikanth Yalavarthi:
> > > >  static struct option lgopts[] = {
> > > > -	{ML_TEST, 1, 0, 0},  {ML_DEVICE_ID, 1, 0, 0}, {ML_SOCKET_ID, 1, 0, 0},
> > > {ML_MODELS, 1, 0, 0},
> > > > -	{ML_DEBUG, 0, 0, 0}, {ML_HELP, 0, 0, 0},      {NULL, 0, 0, 0}};
> > > > +	{ML_TEST, 1, 0, 0},   {ML_DEVICE_ID, 1, 0, 0}, {ML_SOCKET_ID, 1, 0,
> > > 0},
> > > > +	{ML_MODELS, 1, 0, 0}, {ML_FILELIST, 1, 0, 0},  {ML_REPETITIONS, 1, 0,
> > > 0},
> > > > +	{ML_DEBUG, 0, 0, 0},  {ML_HELP, 0, 0, 0},      {NULL, 0, 0, 0}};
> > >
> > > I don't understand the need to have multiple options per line.
> > > When doing a list, it is simpler to read on item per line.
> >
> > This is a result of running checkformat / clang-format tool. The tool is
> automatically arranging multiple options per line in the initial patches. The
> final patch would have one option per line.
> 
> Please do one option per line in each patch.

Done, changes are part of v7.
> 



More information about the dev mailing list