[PATCH 4/4] pcapng: move timestamp calculation into pdump

[David Marchand]

Hello Stephen,

On Thu, Sep 21, 2023 at 6:24 AM Stephen Hemminger
<stephen at networkplumber.org> wrote:
>
> The computation of timestamp is more easily done in pdump
> than pcapng. The initialization is easier and makes the pcapng
> library have no global state.
>
> It also makes it easier to add HW timestamp support later.
>
> Simplify the computation of nanoseconds from TSC to a two
> step process which avoids numeric overflow issues. The previous
> code was not thread safe as well.
>

Bugzilla ID: 1291 ?

This patch (and patch 3) updates some pcapng API, is it worth a RN update?

> Fixes: c882eb544842 ("pcapng: fix timestamp wrapping in output files")

Is it worth backporting?
I would say no, as some API update was needed to fix the issue.
But on the other hand, this is an experimental API, so I prefer to ask.


> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>


-- 
David Marchand