[PATCH] eventdev: fix max link profiles info

Bruce Richardson bruce.richardson at intel.com
Tue Oct 3 18:48:40 CEST 2023


On Tue, Oct 03, 2023 at 08:55:35PM +0530, pbhagavatula at marvell.com wrote:
> From: Pavan Nikhilesh <pbhagavatula at marvell.com>
> 
> Since most of the drivers overwrite the info structure passed
> from the common layer it is not possible to set defaults in
> ``rte_event_dev_info_get`` API.
> Initialize default max_profiles_per_port in the driver layer.
> 
> Fixes: 162aa4e1b479 ("eventdev: introduce link profiles")
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula at marvell.com>
> ---
> Please squash to 162aa4e1b479
> 
Just wondering, is another valid approach to check the return value from
the driver callback and set max_profiles to 1 if it's set to zero by the
driver? That would save modifying all drivers and probably still fix any
issues. [I'm assuming that max_profiles == 0 is invalid, and that every
device by default should report "1" as supported]

/Bruce


More information about the dev mailing list