[PATCH v3] app/testpmd: enable cli for programmable action

Dumitrescu, Cristian cristian.dumitrescu at intel.com
Fri Oct 6 14:35:48 CEST 2023


Hi Qi,

<snip>

> 
> +#define ACTION_PROG_NAME_SIZE_MAX 32
> +#define ACTION_PROG_ARG_NUM_MAX 16
> +#define ACTION_PROG_ARG_VALUE_SIZE_MAX 32

Let's be a bit more generous with some of these sizes, please.

The action name might be hierarchical, i.e. include the control block and table path separated by dots, e.g. "dev5.ingress.forwarding.routing_table.set_next_hop", so:
#define ACTION_PROG_NAME_SIZE_MAX 256

Some parameters could be 128-bit IPv6 addresses, which may be specified in hex with additional characters such as '0x' or ':', so:
#define ACTION_PROG_ARG_VALUE_SIZE_MAX 64

<snip>

Regards,
Cristian


More information about the dev mailing list