[EXT] Re: [PATCH v3 1/2] dmadev: offload to free source buffer

[Amit Prakash Shukla]

Hi Chengwen,

Ack, I will make the changes in next version of the patch.

Thanks,
Amit Shukla

> -----Original Message-----
> From: fengchengwen <fengchengwen at huawei.com>
> Sent: Monday, October 9, 2023 2:29 PM
> To: Amit Prakash Shukla <amitprakashs at marvell.com>; Kevin Laatz
> <kevin.laatz at intel.com>; Bruce Richardson <bruce.richardson at intel.com>
> Cc: dev at dpdk.org; Jerin Jacob Kollanukkaran <jerinj at marvell.com>;
> mb at smartsharesystems.com; conor.walsh at intel.com; Vamsi Krishna
> Attunuru <vattunuru at marvell.com>; g.singh at nxp.com;
> sachin.saxena at oss.nxp.com; hemant.agrawal at nxp.com;
> cheng1.jiang at intel.com; Nithin Kumar Dabilpuram
> <ndabilpuram at marvell.com>; Anoob Joseph <anoobj at marvell.com>
> Subject: Re: [EXT] Re: [PATCH v3 1/2] dmadev: offload to free source buffer
> 
> Hi Amit,
> 
>   Rethink again, I suggest use auto-free to denote this feature.
> 
> So we could re-define as:
>   RTE_DMA_CAPA_M2D_AUTO_FREE
>   RTE_DMA_OP_FLAG_AUTO_FREE
> 
> struct rte_dma_auto_free_param {
>       union {
>           struct {
>               struct rte_mempool *pool;
>           } m2d;
>       };
>       uint64_t reserved[2]; /**< Reserved for future fields. */ }; };
> note: because one vchan only support one DMA direction, so we could use
> union.
> 
> struct rte_dma_vchan_conf {
> 	enum rte_dma_direction direction;
> 	struct rte_dma_port_param src_port;
> 	struct rte_dma_port_param dst_port;
> 	struct rte_dma_auto_free_param auto_free; };
> 
> 
> As for later extension, if support other type auto-free, so could:
> 1. add one capa: RTE_DMA_CAPA_XXX_AUTO_FREE 2. modify
> rte_dma_auto_free_param:
>    struct rte_dma_auto_free_param {
>       union {
>           struct {
>               struct rte_mempool *pool;
>           } m2d;
>           struct {
>               // params;
>           } xxx;
>       };
>       uint64_t reserved[2]; /**< Reserved for future fields. */ };
>     };
> 
> 
> Thanks.
> 

<snip>