[PATCH v5 38/40] app/proc-info: adjust the display format of RSS info

[fengchengwen]

Hi HaiJie,

On 2023/10/11 17:28, Jie Hai wrote:
> This patch splits the length and value of RSS key into two parts,
> removes spaces between RSS keys, and adds line breaks between RSS
> key and RSS hf.
> 
> Before the adjustment, RSS info is shown as:
>   - RSS
> 	  -- RSS len 40 key (hex): 6d 5a 56 da 25 5b e c2 41 67 \
> 	     25 3d 43 a3 8f b0 d0 ca 2b cb ae 7b 30 b4 77 cb 2d \
> 	     a3 80 30 f2 c 6a 42 b7 3b be ac 1 fa -- hf 0x0
> and after:
>   - RSS info
> 	  -- key len : 40
> 	  -- key (hex) : 6d5a56da255b0ec24167253d43a38fb0d0c \
> 		a2bcbae7b30b477cb2da38030f20c6a42b73bbeac01fa
> 	  -- hash function : 0x0

How about convert to string? e.g. hash function: SIMPLE_XOR

> 
> Fixes: 8a37f37fc243 ("app/procinfo: add --show-port")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Jie Hai <haijie1 at huawei.com>
> Signed-off-by: Dongdong Liu <liudongdong3 at huawei.com>
> Acked-by: Reshma Pattan<reshma.pattan at intel.com>
> ---
>  app/proc-info/main.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/app/proc-info/main.c b/app/proc-info/main.c
> index 4509b3c16e36..e98352118db1 100644
> --- a/app/proc-info/main.c
> +++ b/app/proc-info/main.c
> @@ -1178,12 +1178,13 @@ show_port(void)
>  		rss_conf.rss_key_len = dev_info.hash_key_size;
>  		ret = rte_eth_dev_rss_hash_conf_get(i, &rss_conf);
>  		if (ret == 0) {
> -			printf("  - RSS\n");
> -			printf("\t  -- RSS len %u key (hex):",
> +			printf("  - RSS info\n");
> +			printf("\t  -- key len : %u\n",
>  					rss_conf.rss_key_len);
> +			printf("\t  -- key (hex) : ");
>  			for (k = 0; k < rss_conf.rss_key_len; k++)
> -				printf(" %x", rss_conf.rss_key[k]);
> -			printf("\t  -- hf 0x%"PRIx64"\n",
> +				printf("%02x", rss_conf.rss_key[k]);
> +			printf("\n\t  -- hash function : 0x%"PRIx64"\n",
>  					rss_conf.rss_hf);

Suggest %d other PRIx64

>  		}
>  
>