[PATCH] devtools: extend check on compiler builtin atomics

Tyler Retzlaff roretzla at linux.microsoft.com
Tue Oct 17 13:34:29 CEST 2023


On Tue, Oct 17, 2023 at 01:31:25PM +0200, David Marchand wrote:
> rte_memory_order_* should be used when calling the new stdatomic API.
> Add a check on __ATOMIC_* tokens.
> 
> Signed-off-by: David Marchand <david.marchand at redhat.com>
> ---

Acked-by: Tyler Retzlaff <roretzla at linux.microsoft.com>

>  devtools/checkpatches.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
> index 2635923e14..7740152643 100755
> --- a/devtools/checkpatches.sh
> +++ b/devtools/checkpatches.sh
> @@ -113,9 +113,9 @@ check_forbidden_additions() { # <patch>
>  
>  	# refrain from using compiler __atomic_xxx builtins
>  	awk -v FOLDERS="lib drivers app examples" \
> -		-v EXPRESSIONS="__atomic_.*\\\(" \
> +		-v EXPRESSIONS="__atomic_.*\\\( __ATOMIC_(RELAXED|CONSUME|ACQUIRE|RELEASE|ACQ_REL|SEQ_CST)" \
>  		-v RET_ON_FAIL=1 \
> -		-v MESSAGE='Using __atomic_xxx built-ins, prefer rte_atomic_xxx' \
> +		-v MESSAGE='Using __atomic_xxx/__ATOMIC_XXX built-ins, prefer rte_atomic_xxx' \

Not sure if it should say prefer rte_atomic_xxx/rte_memory_order_xxx ?

Either way it catches the problem.



More information about the dev mailing list