[PATCH v4 3/7] ci: allow use of DPDK tools when building examples
Bruce Richardson
bruce.richardson at intel.com
Tue Oct 17 14:28:05 CEST 2023
On Tue, Oct 17, 2023 at 08:24:36AM -0400, Aaron Conole wrote:
> Bruce Richardson <bruce.richardson at intel.com> writes:
>
> > To allow use of the DPDK python scripts (installed in $(prefix)/bin)
> > from within the makefiles of our examples, we need to export the PATH
> > variable with the location of our installed scripts from within our CI
> > scripts. This matches what is already done for other paths e.g. the
> > PKG_CONFIG_PATH variable.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
> > ---
>
> I guess this should work, but it's a bit strange that we need to key off
> something like dpdk-devbind.py. Not a complaint, just an observation.
>
Yes, I also find it a bit strange, but I decided to just copy the style
used for the other paths which also key off a "known-good" file. As you
say, it also works though, which is nice :-)
> Maybe a future change would be to update the meson.build to set the
> exec_prefix variable - but I guess for now that might be a much bigger
> change. But it means we could get the path after setting the pkgconfig
> path and then just run something like:
>
> pkg-config libdpdk --variable=exec_prefix
>
> and wouldn't need to search for the python utility.
>
> As I wrote - it's a more involved change, and I don't think it should
> hold up this patch. Just something to consider for the future (maybe
> Michael or I could look at it)
Thanks for the input.
/Bruce
More information about the dev
mailing list