[PATCH 1/7] vhost: fix missing vring call check on virtqueue access

Maxime Coquelin maxime.coquelin at redhat.com
Fri Oct 20 10:40:53 CEST 2023



On 10/19/23 09:24, David Marchand wrote:
> On Mon, Sep 25, 2023 at 6:36 PM Maxime Coquelin
> <maxime.coquelin at redhat.com> wrote:
>>
>> Acquiring the access lock is not enough to ensure
>> virtqueue's metadata such as vring pointers are valid.
>>
>> The access status must also be checked.
> 
> Even if adding the lock was not enough, I would flag Fixes:
> 6c299bb7322f ("vhost: introduce vring call API")

Makes sense, adding it to v2.

Thanks,
Maxime

>>
>> Fixes: c5736998305d ("vhost: fix missing virtqueue lock protection")
>> Fixes: 830f7e790732 ("vhost: add non-blocking API for posting interrupt")
>> Cc: stable at dpdk.org
>>
>> Reported-by: Li Feng <fengli at smartx.com>
>> Signed-off-by: Maxime Coquelin <maxime.coquelin at redhat.com>
> 
> 



More information about the dev mailing list