[PATCH v2 08/14] eal: make seqcount and seqlock stable

[Mattias Rönnblom]

On 2023-10-20 23:41, Stephen Hemminger wrote:
> These were add back in 22.07 release.
> 
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> Acked-by: Mattias Rönnblom <mattias.ronnblom at ericsson.com>
> ---
>   lib/eal/include/rte_seqcount.h | 23 -----------------------
>   lib/eal/include/rte_seqlock.h  | 21 ---------------------
>   2 files changed, 44 deletions(-)
> 
> diff --git a/lib/eal/include/rte_seqcount.h b/lib/eal/include/rte_seqcount.h
> index 4f9cefb33862..ff8985310377 100644
> --- a/lib/eal/include/rte_seqcount.h
> +++ b/lib/eal/include/rte_seqcount.h
> @@ -41,15 +41,11 @@ typedef struct {
>   #define RTE_SEQCOUNT_INITIALIZER { .sn = 0 }
>   
>   /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice.
> - *
>    * Initialize the sequence counter.
>    *
>    * @param seqcount
>    *   A pointer to the sequence counter.
>    */
> -__rte_experimental
>   static inline void
>   rte_seqcount_init(rte_seqcount_t *seqcount)
>   {
> @@ -57,9 +53,6 @@ rte_seqcount_init(rte_seqcount_t *seqcount)
>   }
>   
>   /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice.
> - *
>    * Begin a read-side critical section.
>    *
>    * A call to this function marks the beginning of a read-side critical
> @@ -101,8 +94,6 @@ rte_seqcount_init(rte_seqcount_t *seqcount)
>    *
>    * @see rte_seqcount_read_retry()
>    */
> -
> -__rte_experimental
>   static inline uint32_t
>   rte_seqcount_read_begin(const rte_seqcount_t *seqcount)
>   {
> @@ -114,9 +105,6 @@ rte_seqcount_read_begin(const rte_seqcount_t *seqcount)
>   }
>   
>   /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice.
> - *
>    * End a read-side critical section.
>    *
>    * A call to this function marks the end of a read-side critical
> @@ -146,8 +134,6 @@ rte_seqcount_read_begin(const rte_seqcount_t *seqcount)
>    *
>    * @see rte_seqcount_read_begin()
>    */
> -
> -__rte_experimental
>   static inline bool
>   rte_seqcount_read_retry(const rte_seqcount_t *seqcount, uint32_t begin_sn)
>   {
> @@ -172,9 +158,6 @@ rte_seqcount_read_retry(const rte_seqcount_t *seqcount, uint32_t begin_sn)
>   }
>   
>   /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice.
> - *
>    * Begin a write-side critical section.
>    *
>    * A call to this function marks the beginning of a write-side
> @@ -196,8 +179,6 @@ rte_seqcount_read_retry(const rte_seqcount_t *seqcount, uint32_t begin_sn)
>    *
>    * @see rte_seqcount_write_end()
>    */
> -
> -__rte_experimental
>   static inline void
>   rte_seqcount_write_begin(rte_seqcount_t *seqcount)
>   {
> @@ -214,9 +195,6 @@ rte_seqcount_write_begin(rte_seqcount_t *seqcount)
>   }
>   
>   /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice.
> - *
>    * End a write-side critical section.
>    *
>    * A call to this function marks the end of the write-side critical
> @@ -228,7 +206,6 @@ rte_seqcount_write_begin(rte_seqcount_t *seqcount)
>    *
>    * @see rte_seqcount_write_begin()
>    */
> -__rte_experimental
>   static inline void
>   rte_seqcount_write_end(rte_seqcount_t *seqcount)
>   {
> diff --git a/lib/eal/include/rte_seqlock.h b/lib/eal/include/rte_seqlock.h
> index fcbb9c586668..589c98188529 100644
> --- a/lib/eal/include/rte_seqlock.h
> +++ b/lib/eal/include/rte_seqlock.h
> @@ -114,9 +114,6 @@ typedef struct {
>   	}
>   
>   /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice.
> - *
>    * Initialize the seqlock.
>    *
>    * This function initializes the seqlock, and leaves the writer-side
> @@ -125,7 +122,6 @@ typedef struct {
>    * @param seqlock
>    *   A pointer to the seqlock.
>    */
> -__rte_experimental
>   static inline void
>   rte_seqlock_init(rte_seqlock_t *seqlock)
>   {
> @@ -134,9 +130,6 @@ rte_seqlock_init(rte_seqlock_t *seqlock)
>   }
>   
>   /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice.
> - *
>    * Begin a read-side critical section.
>    *
>    * See rte_seqcount_read_retry() for details.
> @@ -150,8 +143,6 @@ rte_seqlock_init(rte_seqlock_t *seqlock)
>    * @see rte_seqlock_read_retry()
>    * @see rte_seqcount_read_retry()
>    */
> -
> -__rte_experimental
>   static inline uint32_t
>   rte_seqlock_read_begin(const rte_seqlock_t *seqlock)
>   {
> @@ -159,9 +150,6 @@ rte_seqlock_read_begin(const rte_seqlock_t *seqlock)
>   }
>   
>   /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice.
> - *
>    * End a read-side critical section.
>    *
>    * See rte_seqcount_read_retry() for details.
> @@ -177,7 +165,6 @@ rte_seqlock_read_begin(const rte_seqlock_t *seqlock)
>    *
>    * @see rte_seqlock_read_begin()
>    */
> -__rte_experimental
>   static inline bool
>   rte_seqlock_read_retry(const rte_seqlock_t *seqlock, uint32_t begin_sn)
>   {
> @@ -185,9 +172,6 @@ rte_seqlock_read_retry(const rte_seqlock_t *seqlock, uint32_t begin_sn)
>   }
>   
>   /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice.
> - *
>    * Begin a write-side critical section.
>    *
>    * A call to this function acquires the write lock associated @p
> @@ -212,7 +196,6 @@ rte_seqlock_read_retry(const rte_seqlock_t *seqlock, uint32_t begin_sn)
>    *
>    * @see rte_seqlock_write_unlock()
>    */
> -__rte_experimental
>   static inline void
>   rte_seqlock_write_lock(rte_seqlock_t *seqlock)
>   	__rte_exclusive_lock_function(&seqlock->lock)
> @@ -224,9 +207,6 @@ rte_seqlock_write_lock(rte_seqlock_t *seqlock)
>   }
>   
>   /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice.
> - *
>    * End a write-side critical section.
>    *
>    * A call to this function marks the end of the write-side critical
> @@ -238,7 +218,6 @@ rte_seqlock_write_lock(rte_seqlock_t *seqlock)
>    *
>    * @see rte_seqlock_write_lock()
>    */
> -__rte_experimental
>   static inline void
>   rte_seqlock_write_unlock(rte_seqlock_t *seqlock)
>   	__rte_unlock_function(&seqlock->lock)

Acked-by: Mattias Rönnblom <mattias.ronnblom at ericsson.com>

Thanks!