[PATCH] net/sfc: avoid duplicate configuration restore

Andrew Rybchenko andrew.rybchenko at oktetlabs.ru
Mon Dec 16 12:11:41 CET 2024


MAC address, promiscuous and all-multicast modes are restored correctly
upon device start by the PMD itself. ethdev layer should not duplicate it.

Signed-off-by: Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>
---
 drivers/net/sfc/sfc_ethdev.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c
index 89444f0b4a..82fbdbae9c 100644
--- a/drivers/net/sfc/sfc_ethdev.c
+++ b/drivers/net/sfc/sfc_ethdev.c
@@ -2722,6 +2722,14 @@ sfc_fec_set(struct rte_eth_dev *dev, uint32_t fec_capa)
 	return -rc;
 }
 
+static uint64_t
+sfc_get_restore_flags(__rte_unused struct rte_eth_dev *dev,
+		      __rte_unused enum rte_eth_dev_operation op)
+{
+	/* sfc PMD does not require any configuration restore */
+	return 0;
+}
+
 static const struct eth_dev_ops sfc_eth_dev_ops = {
 	.dev_configure			= sfc_dev_configure,
 	.dev_start			= sfc_dev_start,
@@ -2774,6 +2782,7 @@ static const struct eth_dev_ops sfc_eth_dev_ops = {
 	.fec_get_capability		= sfc_fec_get_capability,
 	.fec_get			= sfc_fec_get,
 	.fec_set			= sfc_fec_set,
+	.get_restore_flags		= sfc_get_restore_flags,
 };
 
 struct sfc_ethdev_init_data {
-- 
2.39.5



More information about the dev mailing list