[PATCH v2 05/14] drivers/bus: use portable variadic macros

David Marchand david.marchand at redhat.com
Mon Dec 23 09:43:38 CET 2024


On Wed, Dec 11, 2024 at 11:09 PM Andre Muezerie
<andremue at linux.microsoft.com> wrote:
>
> Many places are using a GCC extension related to variadic macros,
> where a name prepends the ellipsis. This results in a warning like
> the one below when compiling the code with MSVC:
>
> app\test-pmd\testpmd.h(1314): error C2608:
>     invalid token '...' in macro parameter list
>
> Variadic macros became a standard part of the C language with C99.
> GCC, Clang and MSVC handle them properly.
>
> The fix is to remove the prefix name (args... becomes ...) and use
> __VA_ARGS__.
>
> Signed-off-by: Andre Muezerie <andremue at linux.microsoft.com>

There is one missed occurence:
$ git grep 'define.*[^([:space:]]\.\.\..*)' -- drivers/bus/
drivers/bus/fslmc/qbman/include/compat.h:#define pr_debug(fmt, args...) {}

This does not require a new revision, I'll fix it myself when applying.


-- 
David Marchand



More information about the dev mailing list