[PATCH v4 3/3] bus/pci: fix secondary process save 'FD' problem

David Marchand david.marchand at redhat.com
Mon Jul 1 16:14:30 CEST 2024


On Fri, Jun 28, 2024 at 9:37 AM Chaoyong He <chaoyong.he at corigine.com> wrote:
>
> From: Zerun Fu <zerun.fu at corigine.com>
>
> In the previous logic the 'fd' was only saved in the primary process,
> but for some devices this value is also used in the secondary logic.
>
> For example, the call of 'rte_pci_find_ext_capability()' will fail in
> the secondary process.
>
> Fix this problem by getting and saving the value of 'fd' also in the
> secondary process logic.
>
> Fixes: 9b957f378abf ("pci: merge uio functions for linux and bsd")
> Cc: mukawa at igel.co.jp
> Cc: stable at dpdk.org
>
> Signed-off-by: Zerun Fu <zerun.fu at corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he at corigine.com>
> Reviewed-by: Long Wu <long.wu at corigine.com>
> Reviewed-by: Peng Zhang <peng.zhang at corigine.com>

I did not enter in depth, but I wonder if this change leaks fd in a
secondary process when unmapping UIO resources.


-- 
David Marchand



More information about the dev mailing list