[PATCH 06/10] net/mlx5/hws: fix deletion of action vport
Itamar Gozlan
igozlan at nvidia.com
Sun Jul 7 12:25:27 CEST 2024
From: Erez Shitrit <erezsh at nvidia.com>
No more ignoring this action while destroying it.
Fixes: f8c8a6d8440d ("net/mlx5/hws: add action object")
Cc: erezsh at nvidia.com
Cc: stable at dpdk.org
Signed-off-by: Erez Shitrit <erezsh at nvidia.com>
Acked-by: Matan Azrad <matan at nvidia.com>
---
drivers/net/mlx5/hws/mlx5dr_action.c | 4 ++++
drivers/net/mlx5/hws/mlx5dr_cmd.c | 3 ++-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/hws/mlx5dr_action.c b/drivers/net/mlx5/hws/mlx5dr_action.c
index b90f18df8a..0d90280a7d 100644
--- a/drivers/net/mlx5/hws/mlx5dr_action.c
+++ b/drivers/net/mlx5/hws/mlx5dr_action.c
@@ -2968,6 +2968,7 @@ static void mlx5dr_action_destroy_hws(struct mlx5dr_action *action)
case MLX5DR_ACTION_TYP_ASO_CT:
case MLX5DR_ACTION_TYP_PUSH_VLAN:
case MLX5DR_ACTION_TYP_REMOVE_HEADER:
+ case MLX5DR_ACTION_TYP_VPORT:
mlx5dr_action_destroy_stcs(action);
break;
case MLX5DR_ACTION_TYP_DEST_ROOT:
@@ -3027,6 +3028,9 @@ static void mlx5dr_action_destroy_hws(struct mlx5dr_action *action)
break;
case MLX5DR_ACTION_TYP_LAST:
break;
+ default:
+ DR_LOG(ERR, "Not supported action type: %d", action->type);
+ assert(false);
}
}
diff --git a/drivers/net/mlx5/hws/mlx5dr_cmd.c b/drivers/net/mlx5/hws/mlx5dr_cmd.c
index 72fc9e3d91..a4f778a8a4 100644
--- a/drivers/net/mlx5/hws/mlx5dr_cmd.c
+++ b/drivers/net/mlx5/hws/mlx5dr_cmd.c
@@ -1033,7 +1033,8 @@ int mlx5dr_cmd_generate_wqe(struct ibv_context *ctx,
ret = mlx5_glue->devx_general_cmd(ctx, in, sizeof(in), out, sizeof(out));
if (ret) {
- DR_LOG(ERR, "Failed to write GTA WQE using FW");
+ DR_LOG(ERR, "Failed to write GTA WQE using FW (syndrome: %#x)",
+ mlx5dr_cmd_get_syndrome(out));
rte_errno = errno;
return rte_errno;
}
--
2.39.3
More information about the dev
mailing list