[PATCH] telemetry: fix potential connection issue

Thomas Monjalon thomas at monjalon.net
Sun Jul 7 15:11:48 CEST 2024


26/06/2024 04:13, Jiale, SongX:
> From: Zhichao Zeng <zhichaox.zeng at intel.com>
> > 
> > For calling memcpy when the source and destination addresses are the same,
> > there is a small probability that there will be a copy error issue in some
> > environments, resulting in a failure to connect.
> > 
> > This patch uses memmove instead of memcpy to avoid this issue.
> > 
> > Fixes: b80fe1805eee ("telemetry: introduce backward compatibility")
> > Cc: stable at dpdk.org
> > 
> > Signed-off-by: Zhichao Zeng <zhichaox.zeng at intel.com>
> > ---
> Tested-by: Song Jiale <songx.jiale at intel.com>

It would be cleaner to do a proper parsing before doing any copy (strlcpy, memcpy/memmove).

dirty code dirty fixed for now
Applied





More information about the dev mailing list