[EXTERNAL] Re: [PATCH v2] net/virtio_user: fix issue with converting cq descriptor IOVA address to VA
David Marchand
david.marchand at redhat.com
Fri Jul 12 09:57:20 CEST 2024
On Thu, Jul 11, 2024 at 7:46 PM Srujana Challa <schalla at marvell.com> wrote:
> > > +963,8 @@ virtio_user_handle_ctrl_msg_split(struct virtio_user_dev *dev,
> > struct vring *vri
> > > (struct virtio_pmd_ctrl *)hdr, dlen,
> > > nb_dlen);
> > >
> > > /* Update status */
> > > - *(virtio_net_ctrl_ack *)virtio_user_iova2virt(vring-
> > >desc[idx_status].addr) = status;
> > > + *(virtio_net_ctrl_ack *)
> > > + virtio_user_iova2virt(vring->desc[idx_status].addr,
> > > + use_va) = status;
> >
> > Afaics, no need for reindenting.
> It crossed 100 line boundary actually.
Ah indeed, it is crossed with "use_va".
But it won't be the case when passing dev.
So please don't touch original indent after applying my suggestion.
--
David Marchand
More information about the dev
mailing list