[PATCH v1] net/e1000: do not update link status in secondary process

Jun Wang junwang01 at cestc.cn
Fri Jul 12 13:30:47 CEST 2024


The code to update link status is not safe in secondary process.
If called from secondary it will crash, example from dumpcap:
    eth_em_link_update

Signed-off-by: Jun Wang <junwang01 at cestc.cn>
---
 drivers/net/e1000/em_ethdev.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c
index c5a4dec..f6875b0 100644
--- a/drivers/net/e1000/em_ethdev.c
+++ b/drivers/net/e1000/em_ethdev.c
@@ -1136,6 +1136,9 @@ static int eth_em_pci_remove(struct rte_pci_device *pci_dev)
 	struct rte_eth_link link;
 	int link_up, count;
 
+	if (rte_eal_process_type() != RTE_PROC_PRIMARY)
+		return -1;
+
 	link_up = 0;
 	hw->mac.get_link_status = 1;
 
-- 
1.8.3.1





More information about the dev mailing list