[PATCH v8 01/21] net/ntnic: add ethdev and makes PMD available

[Ferruh Yigit]

On 7/12/2024 4:47 PM, Serhii Iliushyk wrote:
> Add initial ntnic ethdev skeleton and register PCI probe functions
> Update documentation: Device description and feature list
> 
> Signed-off-by: Serhii Iliushyk <sil-plv at napatech.com>
> ---
> v6
> * Remove unused includes
> * Remove EOF markers
> * Remove unnecesarry commpiller flags
> * Update documentation INI and RST files
>         * Remove uncovered features
>         * Add features according to DPDK reqirements
>         * Add link on NT200A02 description
> * Rename res(short for result) to ret(short for return)
> * Fix unnecessary set of the driver name
>         * The driver name is set by macro RTE_PMD_REGISTER_PCI
> * Set sentinel value for PCI id_table
>         * NULL value can lead to the crush on function rte_pci_match
> * Remove unnecessary comments
> v7
> * Move features list to the dedicated patches
> * Update release note file
> ---
>  .mailmap                               |  1 +
>  MAINTAINERS                            |  7 ++++
>  doc/guides/nics/features/ntnic.ini     |  8 +++++
>  doc/guides/nics/index.rst              |  1 +
>  doc/guides/nics/ntnic.rst              | 39 ++++++++++++++++++++
>  doc/guides/rel_notes/release_24_07.rst | 10 ++++++
>  drivers/net/meson.build                |  1 +
>  drivers/net/ntnic/meson.build          | 18 ++++++++++
>  drivers/net/ntnic/ntnic_ethdev.c       | 49 ++++++++++++++++++++++++++
>  9 files changed, 134 insertions(+)
>  create mode 100644 doc/guides/nics/features/ntnic.ini
>  create mode 100644 doc/guides/nics/ntnic.rst
>  create mode 100644 drivers/net/ntnic/meson.build
>  create mode 100644 drivers/net/ntnic/ntnic_ethdev.c
> 

<...>

> diff --git a/MAINTAINERS b/MAINTAINERS
> index 533f707d5f..0359368981 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -855,6 +855,13 @@ F: drivers/net/octeon_ep/
>  F: doc/guides/nics/features/octeon_ep.ini
>  F: doc/guides/nics/octeon_ep.rst
>  
> +Napatech ntnic
> +M: Christian Koue Muf <ckm at napatech.com>
> +M: Serhii Iliushyk <sil-plv at napatech.com>
> +F: drivers/net/ntnic/
> +F: doc/guides/nics/ntnic.rst
> +F: doc/guides/nics/features/ntnic.ini
> +
>

What about updating as "Napatech ntnic - EXPERIMENTAL", when basic
functionality is upstreamed and tested, experimental tag can be removed.

<...>

> diff --git a/doc/guides/rel_notes/release_24_07.rst b/doc/guides/rel_notes/release_24_07.rst
> index e50afed0d5..332a959618 100644
> --- a/doc/guides/rel_notes/release_24_07.rst
> +++ b/doc/guides/rel_notes/release_24_07.rst
> @@ -154,6 +154,16 @@ New Features
>  
>    Added an API that allows the user to reclaim the defer queue with RCU.
>  
> +* **Added Napatech ntnic experimental PMD driver.**
>

What do you think "Added Napatech ntnic net driver."?

> +
> +  * Added the experimental PMD driver
> +
> +    - Ability to initialize the NIC (NT200A02)
> +    - Supporting only one FPGA firmware (9563.55.39)
> +    - Ability to bring up the 100G link
> +    - Supporting QSFP/QSFP+/QSFP28 NIM
> +    - Does not support datapath
> +    - Does not support RTE flow API
>

May drop flow API, as datapath being missing implies it.

Also release notes updates are grouped per device group, and
alphabetically sorted withing group. For this can you please move above
update just below "Marvell cnxk net driver"?