[PATCH v8 10/21] net/ntnic: add FPGA modules for initialization

[Ferruh Yigit]

On 7/12/2024 4:47 PM, Serhii Iliushyk wrote:
> New ntnic FPGA modules:
> - Host Interface (HIF): Basic FPGA info such as prod ID and build time.
> - Inter-Integrated Circuit Controller (IIC): Use the FPGA to access
> 	the other integrated circuits on the ntnic.
> - PCI Express Gen3 (PCIE3): The FPGA part of PCIe3 initialization,
> 	speed tests, and configuration.
> 
> Signed-off-by: Serhii Iliushyk <sil-plv at napatech.com>

<...>

> diff --git a/drivers/net/ntnic/adapter/nt4ga_adapter.c b/drivers/net/ntnic/adapter/nt4ga_adapter.c
> index 7cc3841ecf..c9f228a8ed 100644
> --- a/drivers/net/ntnic/adapter/nt4ga_adapter.c
> +++ b/drivers/net/ntnic/adapter/nt4ga_adapter.c
> @@ -60,7 +60,6 @@ static int nt4ga_adapter_init(struct adapter_info_s *p_adapter_info)
>  	/* ref: DN-0060 section 9 */
>  	p_hw_info->hw_reserved1 = (p_hw_info->pci_device_id >> 12) & 0x000f;
>  
> -	/* mp_dev_name */
>  	p_adapter_info->p_dev_name = p_dev_name;
>  
>  	if (p_dev_name) {
> @@ -73,7 +72,6 @@ static int nt4ga_adapter_init(struct adapter_info_s *p_adapter_info)
>  			p_adapter_info->fpga_info.pciident);
>  	}
>  
> -	/* mp_adapter_id_str */
>  	p_adapter_info->mp_adapter_id_str = p_adapter_id_str;
>  

If above removed comments are not needed, what do you think to not add
them at first place in previous commits?