[v3 02/30] dma/dpaa2: support multiple HW queues

Stephen Hemminger stephen at networkplumber.org
Mon Jul 22 22:19:12 CEST 2024


On Mon, 22 Jul 2024 22:09:02 +0530
Gagandeep Singh <g.singh at nxp.com> wrote:

> index 5954b552b5..945ba71e4a 100644
> --- a/drivers/dma/dpaa2/dpaa2_qdma.c
> +++ b/drivers/dma/dpaa2/dpaa2_qdma.c
> @@ -478,9 +478,9 @@ dpdmai_dev_get_job_us(struct qdma_virt_queue *qdma_vq __rte_unused,
>  
>  static inline uint16_t
>  dpdmai_dev_get_single_job_lf(struct qdma_virt_queue *qdma_vq,
> -			     const struct qbman_fd *fd,
> -			     struct rte_dpaa2_qdma_job **job,
> -			     uint16_t *nb_jobs)
> +	const struct qbman_fd *fd,
> +	struct rte_dpaa2_qdma_job **job,
> +	uint16_t *nb_jobs)

Why are you changing this? The DPDK style is either to line up the args with the paren
or use two tabs here. Changing indentation leads to lots of extra changes which makes
it hard to review. Please, just leave the existing indentation alone or make it
a separate patch.


More information about the dev mailing list