回复: [RFC 18/18] drivers/net: add hinic3 PMD build and doc files

[wangfeifei (J)]

-----邮件原件-----
发件人: Stephen Hemminger <stephen at networkplumber.org> 
发送时间: 2025年4月19日 1:23
收件人: Feifei Wang <wff_light at vip.163.com>
抄送: dev at dpdk.org; chenyi (CY) <chenyi221 at huawei.com>; Wangxin(kunpeng) <wangxin679 at h-partners.com>; wangfeifei (J) <wangfeifei40 at huawei.com>
主题: Re: [RFC 18/18] drivers/net: add hinic3 PMD build and doc files

On Fri, 18 Apr 2025 17:06:04 +0800
Feifei Wang <wff_light at vip.163.com> wrote:

> +cflags += [
> +    '-DHW_CONVERT_ENDIAN',
> +    '-D__HINIC_HUAWEI_SECUREC__',
> +    '-fPIC',
> +    '-fstack-protector-strong',
> +]

What is this?
Should not enable PIC or stack-protector at the driver level.
I assume the other stuff is huawei specific compiler flags.

[Feifei] Got it. We will remove this, and should keep it the same as generic way.

> +if arch_subdir == 'arm' and dpdk_conf.get('RTE_ARCH_64')
> +    cflags += ['-D__ARM64_NEON__']
> +else
> +    cflags += ['-D__X86_64_SSE__']
> +endif


This should already be handled in the existing DPDK meson stuff.
Doing it at a per-driver level seems wrong.
[Feifei] Agree, the next version we will fix.