[PATCH v2 1/6] eal: replace unnecessary comma operator

Konstantin Ananyev konstantin.ananyev at huawei.com
Fri Aug 15 15:48:38 CEST 2025



> Use of comma as statement separator is discouraged and
> reported as warning by clang with -Wcomma
> 
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> ---
>  lib/eal/common/rte_malloc.c | 4 ++--
>  lib/eal/linux/eal_alarm.c   | 6 ++++--
>  2 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/eal/common/rte_malloc.c b/lib/eal/common/rte_malloc.c
> index 3a86c19490..388e5a63b6 100644
> --- a/lib/eal/common/rte_malloc.c
> +++ b/lib/eal/common/rte_malloc.c
> @@ -202,8 +202,8 @@ rte_realloc_socket(void *ptr, size_t size, unsigned int align, int socket)
>  	}
> 
>  	user_size = size;
> -
> -	size = RTE_CACHE_LINE_ROUNDUP(size), align = RTE_CACHE_LINE_ROUNDUP(align);
> +	size = RTE_CACHE_LINE_ROUNDUP(size);
> +	align = RTE_CACHE_LINE_ROUNDUP(align);
> 
>  	/* check requested socket id and alignment matches first, and if ok,
>  	 * see if we can resize block
> diff --git a/lib/eal/linux/eal_alarm.c b/lib/eal/linux/eal_alarm.c
> index eb6a21d4f0..a1433eb867 100644
> --- a/lib/eal/linux/eal_alarm.c
> +++ b/lib/eal/linux/eal_alarm.c
> @@ -125,8 +125,10 @@ eal_alarm_callback(void *arg __rte_unused)
>  		atime.it_value.tv_sec = ap->time.tv_sec;
>  		atime.it_value.tv_nsec = ap->time.tv_usec * NS_PER_US;
>  		/* perform borrow for subtraction if necessary */
> -		if (now.tv_nsec > (ap->time.tv_usec * NS_PER_US))
> -			atime.it_value.tv_sec--, atime.it_value.tv_nsec += US_PER_S * NS_PER_US;
> +		if (now.tv_nsec > (ap->time.tv_usec * NS_PER_US)) {
> +			atime.it_value.tv_sec--;
> +			atime.it_value.tv_nsec += US_PER_S * NS_PER_US;
> +		}
> 
>  		atime.it_value.tv_sec -= now.tv_sec;
>  		atime.it_value.tv_nsec -= now.tv_nsec;
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev at huawei.com>
 

> 2.47.2



More information about the dev mailing list