[EXTERNAL] Re: [PATCH v5 1/1] ethdev: add support to provide link type

[Sunil Kumar Kori]

> On Tue, 19 Aug 2025 11:21:06 +0530
> <skori at marvell.com> wrote:
> 
> > +/**@{@name PORT type
> > + * Ethernet port link connector type
> > + */
> > +enum rte_eth_link_connector {
> > +	RTE_ETH_LINK_CONNECTOR_NONE = 0,     /**< Not defined */
> > +	RTE_ETH_LINK_CONNECTOR_TP,           /**< Twisted Pair */
> > +	RTE_ETH_LINK_CONNECTOR_AUI,          /**< Attachment Unit Interface */
> > +	RTE_ETH_LINK_CONNECTOR_MII,          /**< Media Independent Interface
> */
> > +	RTE_ETH_LINK_CONNECTOR_FIBER,        /**< Optical Fiber Link */
> > +	RTE_ETH_LINK_CONNECTOR_BNC,          /**< BNC Link type for RF
> connection */
> > +	RTE_ETH_LINK_CONNECTOR_DAC,          /**< Direct Attach copper */
> > +	RTE_ETH_LINK_CONNECTOR_SGMII,        /**< Serial Gigabit Media
> Independent Interface */
> > +	RTE_ETH_LINK_CONNECTOR_QSGMII,       /**< Link to multiplex 4 SGMII
> over one serial link */
> > +	RTE_ETH_LINK_CONNECTOR_XFI,          /**< 10 Gigabit Attachment Unit
> Interface */
> > +	RTE_ETH_LINK_CONNECTOR_SFI,          /**< 10 Gigabit Serial Interface for
> optical network */
> > +	RTE_ETH_LINK_CONNECTOR_XLAUI,        /**< 40 Gigabit Attachment Unit
> Interface */
> > +	RTE_ETH_LINK_CONNECTOR_GAUI,         /**< Gigabit Interface for
> 50/100/200 Gbps */
> > +	RTE_ETH_LINK_CONNECTOR_XAUI,         /**< 10 Gigabit Attachment Unit
> Interface */
> > +	RTE_ETH_LINK_CONNECTOR_CAUI,         /**< 100 Gigabit Attachment Unit
> Interface */
> > +	RTE_ETH_LINK_CONNECTOR_LAUI,         /**< 50 Gigabit Attachment Unit
> Interface */
> > +	RTE_ETH_LINK_CONNECTOR_SFP,          /**< Pluggable module for 1
> Gigabit */
> > +	RTE_ETH_LINK_CONNECTOR_SFP_PLUS,     /**< Pluggable module for 10
> Gigabit */
> > +	RTE_ETH_LINK_CONNECTOR_SFP28,        /**< Pluggable module for 25
> Gigabit */
> > +	RTE_ETH_LINK_CONNECTOR_SFP_DD,       /**< Pluggable module for 100
> Gigabit */
> > +	RTE_ETH_LINK_CONNECTOR_QSFP,         /**< Module to mutiplex 4 SFP i.e.
> 4*1=4 Gbps */
> > +	RTE_ETH_LINK_CONNECTOR_QSFP_PLUS,    /**< Module to mutiplex 4
> SFP_PLUS i.e. 4*10=40 Gbps */
> > +	RTE_ETH_LINK_CONNECTOR_QSFP28,       /**< Module to mutiplex 4 SFP28
> i.e. 4*25=100 Gbps */
> > +	RTE_ETH_LINK_CONNECTOR_QSFP56,       /**< Module to mutiplex 4 SFP56
> i.e. 4*50=200 Gbps */
> > +	RTE_ETH_LINK_CONNECTOR_QSFP_DD,      /**< Module to mutiplex 4
> SFP_DD i.e. 4*100=400 Gbps */
> > +	RTE_ETH_LINK_CONNECTOR_OTHER = 31,   /**< non-physical interfaces
> like virtio, ring etc */
> > +};
> > +/**@}*/
> > +
> 
> doc build fails when you add this.
> 
> Please test.
> 
> [30/1996] Generating doxygen-html with a custom command
> FAILED: [code=1] doc/api/html
> /usr/bin/python3 ../doc/api/generate_doxygen.py doc/api/html
> /usr/bin/doxygen doc/api/doxy-api-html.conf
> /home/runner/work/dpdk/dpdk/lib/ethdev/rte_ethdev.h:335: error: Member
> rte_eth_link_connector (enumeration) of file rte_ethdev.h is not documented.
> (warning treated as error, aborting now) Traceback (most recent call last):
>   File "/home/runner/work/dpdk/dpdk/build/../doc/api/generate_doxygen.py",
> line 13, in <module>
>     subprocess.run(doxygen_command, check=True, stdout=out)
>   File "/usr/lib/python3.10/subprocess.py", line 526, in run
>     raise CalledProcessError(retcode, process.args,
> subprocess.CalledProcessError: Command '['/usr/bin/doxyg

My bad, I didn’t notice this. Thanks for pointing it.