[PATCH] app/testpmd: fix flow queue job leaks

Stephen Hemminger stephen at networkplumber.org
Wed Dec 3 01:04:06 CET 2025


On Tue, 18 Nov 2025 11:45:18 +0100
Dariusz Sosnowski <dsosnowski at nvidia.com> wrote:

> +	polled = 0;
> +	success = 0;
> +	while (expected_ops > 0) {
> +		/* Poisoning to make sure PMDs update it in case of error. */
> +		memset(&error, 0x55, sizeof(error));
> +		ret = rte_flow_pull(port_id, queue_id, res, expected_ops, &error);
> +		if (ret < 0) {
> +			port_flow_complain(&error);
> +			free(res);
> +			return ret;
> +		}
> +		if (ret == 0) {
> +			rte_delay_us_sleep(FLOW_QUEUE_FLUSH_SLEEP_US);
> +			continue;
> +		}

Infinite loops with sleep are bad. The poisoning seems unnecessary and not done
elsewhere. Sleeping for 10 us is just unlikely to help much.


More information about the dev mailing list