[PATCH v3 00/11] Assign all unit tests to suites

[Bruce Richardson]

On Mon, Dec 08, 2025 at 11:10:53AM -0800, Stephen Hemminger wrote:
> On Mon,  8 Dec 2025 11:52:34 +0000
> Bruce Richardson <bruce.richardson at intel.com> wrote:
> 
> > Categorize all unit tests into one of the test suites: generally driver
> > tests or fast-tests. In order to add some of the tests to fast tests,
> > some additional work was required, hence the additional patches in this
> > set. Also, make the parameters for asan and hugepages clearer in each
> > test's definition.
> > 
> > V3:
> >  - correct comment in patch 1
> >  - define "attic" suite for unstable tests and add red_autotest to it.
> > 
> > V2:
> > - rename the parameters for fast-test
> > - fix issues with the tests to be added to fast-tests:
> >   * allow loading drivers from secondary processes
> >   * fix undefined behaviour flagged by asan in red test
> >   * skip unrunnable power tests, rather than failing
> > - add tests to driver-test suite also
> > - add patch fixing output in case we have no unattached tests
> > 
> > Bruce Richardson (11):
> >   app/test: make parameters clearer when adding fast tests
> >   app/test: fix undefined behaviour in red autotest
> >   app/test: reduce duration of secondary timer test
> >   app/test: fix timer loop hang on secondary process failure
> >   eal: add internal APIs to query loaded driver paths
> >   app/test: pass loaded driver info to secondary procs
> >   app/test: skip power capabilities test if unsupported
> >   app/test: add some unattached tests to fast-test suite
> >   app/test: add tests to driver test suite
> >   buildtools/get-test-suites: suppress empty output
> >   app/test: move red autotest to attic
> > 
> >  app/test/process.h                     | 28 ++++++++++++-
> >  app/test/suites/meson.build            | 14 ++++++-
> >  app/test/test.h                        | 13 ++++++-
> >  app/test/test_acl.c                    |  2 +-
> >  app/test/test_alarm.c                  |  2 +-
> >  app/test/test_argparse.c               |  2 +-
> >  app/test/test_atomic.c                 |  2 +-
> >  app/test/test_bitcount.c               |  2 +-
> >  app/test/test_bitmap.c                 |  2 +-
> >  app/test/test_bitops.c                 |  2 +-
> >  app/test/test_bitratestats.c           |  2 +-
> >  app/test/test_bitset.c                 |  2 +-
> >  app/test/test_bpf.c                    |  6 +--
> >  app/test/test_byteorder.c              |  2 +-
> >  app/test/test_cfgfile.c                |  2 +-
> >  app/test/test_cksum.c                  |  2 +-
> >  app/test/test_cmdline.c                |  2 +-
> >  app/test/test_common.c                 |  2 +-
> >  app/test/test_compressdev.c            |  2 +-
> >  app/test/test_cpuflags.c               |  2 +-
> >  app/test/test_crc.c                    |  2 +-
> >  app/test/test_cryptodev_crosscheck.c   |  2 +-
> >  app/test/test_cycles.c                 |  2 +-
> >  app/test/test_debug.c                  |  2 +-
> >  app/test/test_devargs.c                |  2 +-
> >  app/test/test_dispatcher.c             |  2 +-
> >  app/test/test_distributor.c            |  2 +-
> >  app/test/test_eal_flags.c              | 24 ++++++------
> >  app/test/test_eal_fs.c                 |  2 +-
> >  app/test/test_errno.c                  |  2 +-
> >  app/test/test_ethdev_api.c             |  2 +-
> >  app/test/test_ethdev_link.c            |  2 +-
> >  app/test/test_event_crypto_adapter.c   |  2 +-
> >  app/test/test_event_eth_rx_adapter.c   |  4 +-
> >  app/test/test_event_eth_tx_adapter.c   |  2 +-
> >  app/test/test_event_ring.c             |  2 +-
> >  app/test/test_event_timer_adapter.c    |  2 +-
> >  app/test/test_event_vector_adapter.c   |  2 +-
> >  app/test/test_eventdev.c               |  4 +-
> >  app/test/test_external_mem.c           |  2 +-
> >  app/test/test_fbarray.c                |  2 +-
> >  app/test/test_fib.c                    |  2 +-
> >  app/test/test_fib6.c                   |  2 +-
> >  app/test/test_func_reentrancy.c        |  2 +-
> >  app/test/test_graph.c                  |  4 +-
> >  app/test/test_graph_feature_arc.c      |  2 +-
> >  app/test/test_hash.c                   |  2 +-
> >  app/test/test_hash_readwrite.c         |  2 +-
> >  app/test/test_interrupts.c             |  2 +-
> >  app/test/test_ipfrag.c                 |  2 +-
> >  app/test/test_ipsec.c                  |  2 +-
> >  app/test/test_ipsec_sad.c              |  2 +-
> >  app/test/test_kvargs.c                 |  2 +-
> >  app/test/test_latencystats.c           |  2 +-
> >  app/test/test_lcore_var.c              |  2 +-
> >  app/test/test_lcores.c                 |  2 +-
> >  app/test/test_logs.c                   |  2 +-
> >  app/test/test_lpm.c                    |  2 +-
> >  app/test/test_lpm6.c                   |  2 +-
> >  app/test/test_malloc.c                 |  2 +-
> >  app/test/test_mbuf.c                   |  2 +-
> >  app/test/test_mcslock.c                |  2 +-
> >  app/test/test_member.c                 |  2 +-
> >  app/test/test_memcpy.c                 |  2 +-
> >  app/test/test_memory.c                 |  2 +-
> >  app/test/test_mempool.c                |  2 +-
> >  app/test/test_memzone.c                |  2 +-
> >  app/test/test_meter.c                  |  2 +-
> >  app/test/test_metrics.c                |  2 +-
> >  app/test/test_mp_secondary.c           |  2 +-
> >  app/test/test_net_ether.c              |  2 +-
> >  app/test/test_net_ip6.c                |  2 +-
> >  app/test/test_pcapng.c                 |  2 +-
> >  app/test/test_pdcp.c                   |  2 +-
> >  app/test/test_pdump.c                  |  2 +-
> >  app/test/test_per_lcore.c              |  2 +-
> >  app/test/test_pflock.c                 |  2 +-
> >  app/test/test_pie.c                    |  2 +-
> >  app/test/test_pmd_ring.c               |  2 +-
> >  app/test/test_pmu.c                    |  2 +-
> >  app/test/test_power.c                  |  2 +-
> >  app/test/test_power_cpufreq.c          |  6 +--
> >  app/test/test_power_intel_uncore.c     |  2 +-
> >  app/test/test_power_kvm_vm.c           |  2 +-
> >  app/test/test_prefetch.c               |  2 +-
> >  app/test/test_ptr_compress.c           |  2 +-
> >  app/test/test_rawdev.c                 |  2 +-
> >  app/test/test_rcu_qsbr.c               |  2 +-
> >  app/test/test_red.c                    |  2 +-
> >  app/test/test_reorder.c                |  2 +-
> >  app/test/test_rib.c                    |  2 +-
> >  app/test/test_rib6.c                   |  2 +-
> >  app/test/test_ring.c                   |  2 +-
> >  app/test/test_rwlock.c                 |  8 ++--
> >  app/test/test_sched.c                  |  2 +-
> >  app/test/test_security.c               |  2 +-
> >  app/test/test_security_inline_macsec.c |  2 +-
> >  app/test/test_security_inline_proto.c  |  6 +--
> >  app/test/test_seqlock.c                |  2 +-
> >  app/test/test_service_cores.c          |  2 +-
> >  app/test/test_soring.c                 |  2 +-
> >  app/test/test_spinlock.c               |  2 +-
> >  app/test/test_stack.c                  |  4 +-
> >  app/test/test_string_fns.c             |  2 +-
> >  app/test/test_table.c                  |  2 +-
> >  app/test/test_tailq.c                  |  2 +-
> >  app/test/test_telemetry_data.c         |  2 +-
> >  app/test/test_telemetry_json.c         |  2 +-
> >  app/test/test_thash.c                  |  2 +-
> >  app/test/test_threads.c                |  2 +-
> >  app/test/test_ticketlock.c             |  2 +-
> >  app/test/test_timer.c                  |  2 +-
> >  app/test/test_timer_secondary.c        | 13 ++++---
> >  app/test/test_trace.c                  |  2 +-
> >  app/test/test_vdev.c                   |  2 +-
> >  app/test/test_version.c                |  2 +-
> >  buildtools/get-test-suites.py          |  5 ++-
> >  doc/guides/contributing/unit_test.rst  | 10 +++--
> >  lib/eal/common/eal_common_options.c    | 54 ++++++++++++++++++++++++--
> >  lib/eal/include/rte_eal.h              | 52 +++++++++++++++++++++++++
> >  lib/sched/rte_red.h                    |  9 ++++-
> >  121 files changed, 313 insertions(+), 157 deletions(-)
> > 
> > --
> > 2.51.0
> > 
> 
> 
> Overall looks good, one comment is to try and make sure the new
> functions are internal only? or experimental?

I think internal-only. I've marked them in doxygen as internal-only but did
not put it in the export line. I don't see the need for apps to use these
APIs, so let's limit the scope as much as possible, because we can always
open it up further later.

/Bruce