[PATCH dpdk 1/2] graph: always count objects and calls

Morten Brørup mb at smartsharesystems.com
Tue Dec 9 12:13:16 CET 2025


> From: Robin Jarry [mailto:rjarry at redhat.com]
> Sent: Tuesday, 9 December 2025 10.13
> 
> Jerin Jacob, Dec 09, 2025 at 10:09:
> > By default, RTE_LIBRTE_GRAPH_STATS is enabled in distro build. So why
> > need such changes?
> 
> This makes sense with the next patch in fact.
> 
> The user (e.g. grout) may need to collect the number of processed
> objects in order to make runtime decisions. But the cost of rdtsc() may
> be too high and it may be a good thing to disable it unless trying to
> benchmark/debug specific issues.

Looking at patch 2/2, I disagree with the approach.

RTE_LIBRTE_GRAPH_STATS should control all stats, incl. total_calls and total_objs.
Then, if enabled, the total_cycles stats can be controlled by rte_graph_cycle_stats_enable().

Your v1 series introduces unnecessary overhead for applications not caring about total_calls/total_objs stats and thus built without RTE_LIBRTE_GRAPH_STATS.



More information about the dev mailing list