[PATCH v3] ethdev: fix the bug where the flag variables are assigned

Thomas Monjalon thomas at monjalon.net
Sun Jun 8 18:49:14 CEST 2025


22/05/2025 09:42, Sunyang Wu:
> Set the values of the promiscuous and all_multicast variables
> according to the return value.
> 
> Fixes: af75078fece3 ("first public release")

This is reset to 0 since day 1, so next root cause is not needed.

> Fixes: de5ccf0775ae ("ethdev: do nothing if all-multicast mode is
> applied again")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Morten Brørup <mb at smartsharesystems.com>
> Signed-off-by: Sunyang Wu <sunyang.wu at jaguarmicro.com>

Acked-by: Thomas Monjalon <thomas at monjalon.net>

> -	dev->data->promiscuous = 0;
>  	diag = dev->dev_ops->promiscuous_disable(dev);
> -	if (diag != 0)
> -		dev->data->promiscuous = 1;
> +	if (!diag)
> +		dev->data->promiscuous = 0;

Updated the commit log to explain the issue,
and changed the check to compare diag with explicit 0 for success.

Applied, thanks.




More information about the dev mailing list