[RFC PATCH] mempool: Fix some Coverity defects

Stephen Hemminger stephen at networkplumber.org
Mon Jun 9 17:25:45 CEST 2025


On Mon,  9 Jun 2025 14:42:26 +0000
Morten Brørup <mb at smartsharesystems.com> wrote:

> @@ -141,8 +141,13 @@ rte_mem_page_size(void)
>  {
>  	static size_t page_size;
>  
> -	if (!page_size)
> +	if (page_size == 0) {
> +		errno = 0; /* man sysconf(3) */
>  		page_size = sysconf(_SC_PAGESIZE);
> +		if ((ssize_t)page_size < 0)
> +			rte_panic("sysconf(_SC_PAGESIZE) failed: %s",
> +					errno == 0 ? "Indeterminate" : strerror(errno));
> +	}

Why not make page_size a ssize_t or long?
The return value of sysconf is long.
Not sure if setting errno to zero is required, sysconf only touchs it if return value is negative.


More information about the dev mailing list