[PATCH 1/3] net/hns3: fix the hardware GRO function is abnormal

huangdengdui huangdengdui at huawei.com
Tue Jun 10 03:27:48 CEST 2025


On 2025/6/10 1:13, Stephen Hemminger wrote:
> On Mon, 9 Jun 2025 21:06:49 +0800
> Dengdui Huang <huangdengdui at huawei.com> wrote:
> 
>> +	rem = dma_addr & (HNS3_RX_DMA_ADDR_ALIGN_128 - 1);
>> +	if ((rx_offload & RTE_ETH_RX_OFFLOAD_TCP_LRO) && rem > 0) {
>> +		hns3_err(hw, "Hardware GRO is not supported when mbuf DMA "
>> +			 "address is 64-byte aligned");
>> +		return -EINVAL;
> 
> Best to not break messages across source lines, it makes it harder for users
> and tools looking for error messages in the source.
> 
> I.e do:
> 		hns3_err(hw, 
> 			 "Hardware GRO is not supported for if mbuf DMA not 64-byte aligned");
> 			 "
> I can fix during merge if that is ok? or you can resubmit

I made a mistake, can you help me fix it when merging?

Thanks


More information about the dev mailing list