[PATCH v6 3/4] buildtools: embed driver information with MSVC

[David Marchand]

From: Andre Muezerie <andremue at linux.microsoft.com>

The archiver tool from the MSVC toolset is lib.exe. It has different
parameters then it's GNU counterpart "ar".

buildtools\meson.build was updated to use lib.exe when MSVC compiler is
used. This is to allow the code to be built without requiring GNU "ar"
to be installed in that scenario.

Script gen-pmdinfo-cfile.py was updated to use the correct parameters
when using lib.exe.

Signed-off-by: Andre Muezerie <andremue at linux.microsoft.com>
---
 buildtools/gen-pmdinfo-cfile.py | 25 ++++++++++++++++++++-----
 buildtools/meson.build          |  2 ++
 buildtools/pmdinfogen.py        | 11 ++++++-----
 3 files changed, 28 insertions(+), 10 deletions(-)

diff --git a/buildtools/gen-pmdinfo-cfile.py b/buildtools/gen-pmdinfo-cfile.py
index 8ffc192c40..5d2e8e076e 100644
--- a/buildtools/gen-pmdinfo-cfile.py
+++ b/buildtools/gen-pmdinfo-cfile.py
@@ -6,16 +6,31 @@
 import subprocess
 import sys
 
-_, ar, tmp_dir, archive, output, *pmdinfogen = sys.argv
+_, archiver, tmp_dir, archive, output, *pmdinfogen = sys.argv
 paths = []
-for name in subprocess.run([ar, "t", archive], stdout=subprocess.PIPE,
-                            check=True).stdout.decode().splitlines():
+if archiver == "lib":
+    archiver_options = ["/LIST", "/NOLOGO"]
+else:
+    archiver_options = ["t"]
+
+for name in (
+    subprocess.run(
+        [archiver] + archiver_options + [archive],
+        stdout=subprocess.PIPE,
+        check=True,
+    )
+    .stdout.decode()
+    .splitlines()
+):
     if os.path.exists(name):
         paths.append(name)
     else:
         if not os.path.exists(tmp_dir):
             os.makedirs(tmp_dir)
-        subprocess.run([ar, "x", os.path.abspath(archive), name],
-                        check=True, cwd=tmp_dir)
+        if archiver == "lib":
+            run_args = [archiver, f"/EXTRACT:{name}", os.path.abspath(archive)]
+        else:
+            run_args = [archiver, "x", os.path.abspath(archive), name]
+        subprocess.run(run_args, check=True, cwd=tmp_dir)
         paths.append(os.path.join(tmp_dir, name))
 subprocess.run(pmdinfogen + paths + [output], check=True)
diff --git a/buildtools/meson.build b/buildtools/meson.build
index 822e79502a..7b5e449cdb 100644
--- a/buildtools/meson.build
+++ b/buildtools/meson.build
@@ -44,6 +44,8 @@ pmdinfogen = py3 + files('pmdinfogen.py')
 if host_machine.system() == 'windows'
     if cc.get_id() == 'gcc'
         pmdinfo += 'ar'
+    elif cc.get_id() == 'msvc'
+        pmdinfo += 'lib'
     else
         pmdinfo += 'llvm-ar'
     endif
diff --git a/buildtools/pmdinfogen.py b/buildtools/pmdinfogen.py
index dfb89500c0..68db9e5fb6 100755
--- a/buildtools/pmdinfogen.py
+++ b/buildtools/pmdinfogen.py
@@ -87,7 +87,7 @@ def get_value(self, offset, size):
     @property
     def string_value(self):
         value = self._symbol.get_value(0)
-        return coff.decode_asciiz(value) if value else ''
+        return coff.decode_asciiz(value) if value else ""
 
 
 class COFFImage:
@@ -192,7 +192,7 @@ def dump(self, file):
         dumped = json.dumps(self.__dict__)
         escaped = dumped.replace('"', '\\"')
         print(
-            'const char %s_pmd_info[] __attribute__((used)) = "PMD_INFO_STRING= %s";'
+            'RTE_PMD_EXPORT_SYMBOL(const char, %s_pmd_info)[] = "PMD_INFO_STRING= %s";'
             % (self.name, escaped),
             file=file,
         )
@@ -215,7 +215,7 @@ def parse_args():
     parser = argparse.ArgumentParser()
     parser.add_argument("format", help="object file format, 'elf' or 'coff'")
     parser.add_argument(
-        "input", nargs='+', help="input object file path or '-' for stdin"
+        "input", nargs="+", help="input object file path or '-' for stdin"
     )
     parser.add_argument("output", help="output C file path or '-' for stdout")
     return parser.parse_args()
@@ -252,13 +252,14 @@ def open_output(path):
 
 def write_header(output):
     output.write(
-        "static __attribute__((unused)) const char *generator = \"%s\";\n" % sys.argv[0]
+        "#include <dev_driver.h>\n"
+        'static __rte_unused const char *generator = "%s";\n' % sys.argv[0]
     )
 
 
 def main():
     args = parse_args()
-    if args.input.count('-') > 1:
+    if args.input.count("-") > 1:
         raise Exception("'-' input cannot be used multiple times")
     if args.format == "elf" and "ELFFile" not in globals():
         raise Exception("elftools module not found")
-- 
2.49.0