[PATCH v3 2/3] eal: handle sysconf(_SC_PAGESIZE) negative return value
Morten Brørup
mb at smartsharesystems.com
Fri Jun 27 18:38:53 CEST 2025
> From: Thomas Monjalon [mailto:thomas at monjalon.net]
> Sent: Friday, 27 June 2025 17.58
>
> 24/06/2025 10:03, Morten Brørup:
> > + if ((ssize_t)page_size < 0)
> > + rte_panic("sysconf(_SC_PAGESIZE) failed: %s",
> > + errno == 0 ? "Indeterminate" :
> strerror(errno));
>
> We don't want more rte_panic().
> You could log the problem and return 0 here.
> It will be a problem later, but it may allow the application to cleanup
> instead of abrupting crashing.
Disagree.
That would be likely to cause crash with division by zero later.
Better to fail early.
More information about the dev
mailing list