[EXTERNAL] Re: [PATCH] devtools: fix regex of cnxk skip files
Pavan Nikhilesh Bhagavatula
pbhagavatula at marvell.com
Thu Mar 6 17:22:44 CET 2025
> 06/03/2025 16:25, pbhagavatula at marvell.com:
> > From: Pavan Nikhilesh <pbhagavatula at marvell.com>
> >
> > SKIP_FILES should include the path of the file.
> > Update the regex to match the path.
> >
> > Fixes: dd88f51a5725 ("devtools: forbid DPDK API in cnxk base driver")
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula at marvell.com>
> > ---
> > - -v SKIP_FILES='roc_platform*' \
> > + -v SKIP_FILES='.*roc_platform*' \
>
> I don't think it is what you want.
> The last part should be .*
>
I tested with 0001-common-cnxk-support-for-inline-inbound-queue.patch
with SKIP_FILES='roc_platform.*' and It doesn’t work.
diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 63638bc7fa35..64f7b316ea0a 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -236,7 +236,7 @@ check_forbidden_additions() { # <patch>
# forbid rte_ symbols in cnxk base driver
awk -v FOLDERS='drivers/common/cnxk/roc_*' \
- -v SKIP_FILES='.*roc_platform*' \
+ -v SKIP_FILES='roc_platform.*' \
-v EXPRESSIONS="rte_ RTE_" \
-v RET_ON_FAIL=1 \
-v MESSAGE='Use plt_ symbols instead of rte_ API in cnxk base driver' \
(python-venv) lab_pvn at lab-pvn dpdk.org main ± ./devtools/checkpatches.sh 0001-common-cnxk-support-for-inline-inbound-queue.patch
### [PATCH] common/cnxk: support for inline inbound queue
total: 0 errors, 0 warnings, 1 checks, 1173 lines checked
Warning in drivers/common/cnxk/roc_platform.h:
Use plt_ symbols instead of rte_ API in cnxk base driver
More information about the dev
mailing list