[PATCH] net/intel: remove unnecessary compiler flag for mingw
Andre Muezerie
andremue at linux.microsoft.com
Thu Mar 13 19:24:43 CET 2025
On Wed, Mar 12, 2025 at 03:54:58PM +0000, Bruce Richardson wrote:
> There was an issue with building DPDK using mingw v8.1[1], which
> required using the "-fno-asynchronous-unwind-tables" compiler flag when
> building using the mingw compiler. However, recent versions of the
> compiler no longer seem to need this flag, so remove it.
>
> [1] https://inbox.dpdk.org/dev/CAJFAV8z3qFhT9Vv5xOpLhi74BYAht2YCfL2ffLrmei4hfSG5jg@mail.gmail.com
>
> Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
> ---
> drivers/net/intel/i40e/meson.build | 4 ----
> drivers/net/intel/iavf/meson.build | 4 ----
> drivers/net/intel/ice/base/meson.build | 4 ----
> drivers/net/intel/ice/meson.build | 4 ----
> drivers/net/intel/ixgbe/meson.build | 3 ---
> 5 files changed, 19 deletions(-)
>
> diff --git a/drivers/net/intel/i40e/meson.build b/drivers/net/intel/i40e/meson.build
> index 2973ed1a01..15993393fb 100644
> --- a/drivers/net/intel/i40e/meson.build
> +++ b/drivers/net/intel/i40e/meson.build
> @@ -41,10 +41,6 @@ includes += include_directories('base')
> if arch_subdir == 'x86'
> sources += files('i40e_rxtx_vec_sse.c')
>
> - if is_windows and cc.get_id() != 'clang'
> - cflags += ['-fno-asynchronous-unwind-tables']
> - endif
> -
> i40e_avx2_lib = static_library('i40e_avx2_lib',
> 'i40e_rxtx_vec_avx2.c',
> dependencies: [static_rte_ethdev, static_rte_kvargs, static_rte_hash],
> diff --git a/drivers/net/intel/iavf/meson.build b/drivers/net/intel/iavf/meson.build
> index f7eac7c57a..833a63e6c8 100644
> --- a/drivers/net/intel/iavf/meson.build
> +++ b/drivers/net/intel/iavf/meson.build
> @@ -29,10 +29,6 @@ includes += include_directories('base')
> if arch_subdir == 'x86'
> sources += files('iavf_rxtx_vec_sse.c')
>
> - if is_windows and cc.get_id() != 'clang'
> - cflags += ['-fno-asynchronous-unwind-tables']
> - endif
> -
> iavf_avx2_lib = static_library('iavf_avx2_lib',
> 'iavf_rxtx_vec_avx2.c',
> dependencies: [static_rte_ethdev],
> diff --git a/drivers/net/intel/ice/base/meson.build b/drivers/net/intel/ice/base/meson.build
> index 59202df661..38d092c370 100644
> --- a/drivers/net/intel/ice/base/meson.build
> +++ b/drivers/net/intel/ice/base/meson.build
> @@ -49,10 +49,6 @@ if (toolchain == 'gcc' and cc.version().version_compare('>=11.0.0'))
> error_cflags += ['-Wno-array-bounds']
> endif
>
> -if is_windows and cc.get_id() == 'gcc'
> - cflags += ['-fno-asynchronous-unwind-tables']
> -endif
> -
> c_args = cflags
>
> foreach flag: error_cflags
> diff --git a/drivers/net/intel/ice/meson.build b/drivers/net/intel/ice/meson.build
> index cbdf38c1c4..4d8f71cd4a 100644
> --- a/drivers/net/intel/ice/meson.build
> +++ b/drivers/net/intel/ice/meson.build
> @@ -35,10 +35,6 @@ endif
> if arch_subdir == 'x86'
> sources += files('ice_rxtx_vec_sse.c')
>
> - if is_windows and cc.get_id() != 'clang'
> - cflags += ['-fno-asynchronous-unwind-tables']
> - endif
> -
> ice_avx2_lib = static_library('ice_avx2_lib',
> 'ice_rxtx_vec_avx2.c',
> dependencies: [static_rte_ethdev, static_rte_hash],
> diff --git a/drivers/net/intel/ixgbe/meson.build b/drivers/net/intel/ixgbe/meson.build
> index 0ae12dd5ff..0bee736a2c 100644
> --- a/drivers/net/intel/ixgbe/meson.build
> +++ b/drivers/net/intel/ixgbe/meson.build
> @@ -27,9 +27,6 @@ deps += ['hash', 'security']
> if arch_subdir == 'x86'
> sources += files('ixgbe_rxtx_vec_sse.c')
> sources += files('ixgbe_recycle_mbufs_vec_common.c')
> - if is_windows and cc.get_id() != 'clang'
> - cflags += ['-fno-asynchronous-unwind-tables']
> - endif
> elif arch_subdir == 'arm'
> sources += files('ixgbe_rxtx_vec_neon.c')
> sources += files('ixgbe_recycle_mbufs_vec_common.c')
> --
> 2.43.0
I'm fine with these changes.
Acked-by: Andre Muezerie <andremue at linux.microsoft.com>
More information about the dev
mailing list