[PATCH v3 03/13] net/ixgbe: create common Rx queue structure
Bruce Richardson
bruce.richardson at intel.com
Wed May 14 18:45:44 CEST 2025
On Mon, May 12, 2025 at 01:54:29PM +0100, Anatoly Burakov wrote:
> In preparation for deduplication effort, generalize the Rx queue structure.
>
> Most of the fields are simply moved to common/rx.h, clarifying the comments
> where necessary. There are some instances where the field is renamed when
> moving, to make it more consistent with the rest of the codebase.
>
> Specifically, the following fields are renamed:
>
> - rdt_reg_addr -> qrx_tail (Rx ring tail register address)
> - rx_using_sse -> vector_rx (indicates if vectorized path is enabled)
> - mb_pool -> mp (other drivers use this name)
>
> Additionally, some per-driver defines are now also moved to aforementioned
> common Rx header, and re-defined in the driver using said common values.
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov at intel.com>
> ---
> drivers/net/intel/common/rx.h | 62 ++++++++
> drivers/net/intel/ixgbe/ixgbe_ethdev.c | 8 +-
> .../ixgbe/ixgbe_recycle_mbufs_vec_common.c | 8 +-
> drivers/net/intel/ixgbe/ixgbe_rxtx.c | 149 +++++++++---------
> drivers/net/intel/ixgbe/ixgbe_rxtx.h | 67 +-------
> .../net/intel/ixgbe/ixgbe_rxtx_vec_common.h | 4 +-
> drivers/net/intel/ixgbe/ixgbe_rxtx_vec_neon.c | 22 +--
> drivers/net/intel/ixgbe/ixgbe_rxtx_vec_sse.c | 22 +--
> 8 files changed, 172 insertions(+), 170 deletions(-)
>
I think for ease of git history review, I think I'd like this split into
two patches - one for the ixgbe changes to rename the fields, and then a
second patch to just move the structure to common.
/Bruce
More information about the dev
mailing list