[PATCH] net/tap: fix add qdisc failed when create tap
    Stephen Hemminger 
    stephen at networkplumber.org
       
    Tue May 20 17:55:20 CEST 2025
    
    
  
On Mon, 12 May 2025 16:22:04 +0800
luyan <973788536 at qq.com> wrote:
> From: luyan <luyan at cmss.chinamobile.com>
> 
> The errno variable was assigned a positive value in the previous handling,
> but here it is compared against -EEXIST,
> When the tap already exists, this would falsely report an error.
> 
> Signed-off-by: luyan <luyan at cmss.chinamobile.com>
Patch looks good, but the commit message needs a couple of changes.
* DPDK uses a .mailmap file to keep track of all the contributors.
  You should add your email to that.
* Please use your full legal name in the Signed-off-by: portion.
  Is that your full name?
* Since this fixes a bug, please add a fixes tag like:
Fixes: 6fc6de7e0eaf ("net/tap: update netlink error code management")
    
    
More information about the dev
mailing list