[PATCH] eal: fix return value of lcore role

Konstantin Ananyev konstantin.ananyev at huawei.com
Wed May 21 13:26:13 CEST 2025



> 
> From: Pavan Nikhilesh <pbhagavatula at marvell.com>
> 
> Update rte_lcore_has_role() to return false instead of a
> negative value for invalid lcore IDs, removing the need
> for callers to pre-validate the ID.
> 
> Fixes: b0a1502a277c ("eal: make semantics of lcore role function more intuitive")
> Cc: stable at dpdk.org
> 
> Suggested-by: Morten Brørup <mb at smartsharesystems.com>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula at marvell.com>
> ---
>  lib/eal/common/eal_common_lcore.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/eal/common/eal_common_lcore.c b/lib/eal/common/eal_common_lcore.c
> index 294267177d..9dd6c72055 100644
> --- a/lib/eal/common/eal_common_lcore.c
> +++ b/lib/eal/common/eal_common_lcore.c
> @@ -87,7 +87,7 @@ rte_lcore_has_role(unsigned int lcore_id, enum rte_lcore_role_t role)
>  	struct rte_config *cfg = rte_eal_get_configuration();
> 
>  	if (lcore_id >= RTE_MAX_LCORE)
> -		return -EINVAL;
> +		return 0;
> 
>  	return cfg->lcore_role[lcore_id] == role;
>  }
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev at huawei.com>
 
> 2.43.0



More information about the dev mailing list