[PATCH] check-spdk: check that tag is on first line
Stephen Hemminger
stephen at networkplumber.org
Wed Nov 5 23:28:10 CET 2025
For C files the tag needs to be on the first line.
Add a check for that.
Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
---
devtools/check-spdx-tag.sh | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/devtools/check-spdx-tag.sh b/devtools/check-spdx-tag.sh
index 984825026e..cbb6cd3a8d 100755
--- a/devtools/check-spdx-tag.sh
+++ b/devtools/check-spdx-tag.sh
@@ -67,6 +67,17 @@ check_boilerplate() {
$quiet || cat $tmpfile
}
+check_firstline() {
+ if $verbose ; then
+ echo "Files with license text not on first line"
+ echo "-----------------------------------------"
+ fi
+ git grep -n SPDX-License-Identifier -- '*.[ch]' | awk -F: '$2 != 1 { print $1}' >$tmpfile
+
+ not_first=$(wc -l < $tmpfile)
+ $quiet || cat $tmpfile
+}
+
while getopts qvh ARG ; do
case $ARG in
q ) quiet=true ;;
@@ -89,5 +100,8 @@ $verbose && echo
check_boilerplate
$verbose && echo
-echo "total: $missing_spdx missing SPDX, $wrong_license license errors, $warnings warnings"
+check_firstline
+$verbose && echo
+
+echo "total: $missing_spdx missing SPDX, $not_first not on first line, $wrong_license license errors, $warnings warnings"
exit $((missing_spdx + wrong_license))
--
2.51.0
More information about the dev
mailing list